Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag allowing api-documenter to sort functions by first param #6623

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

hsubox76
Copy link
Contributor

Attempting to clean up pages with large groups of functions such as https://firebase.google.com/docs/reference/js/auth by grouping them by first param.

Will gate this behind a flag, --sort-functions so that the change will not be forced on other consumers of our api-documenter fork (functions and admin teams).

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2022

🦋 Changeset detected

Latest commit: c9cf40f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 22, 2022

@hsubox76 hsubox76 marked this pull request as ready for review October 13, 2022 18:16
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit d922816 into master Oct 13, 2022
@hsubox76 hsubox76 deleted the ch-doc-order branch October 13, 2022 20:53
@firebase firebase locked and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants