Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version bump for api-documenter #6701

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Fix version bump for api-documenter #6701

merged 2 commits into from
Oct 17, 2022

Conversation

hsubox76
Copy link
Contributor

@firebase/api-documenter is excluded from changesets so I guess we update it manually. There is a minor bump in #6623 and a patch bump in #6696 so that comes out to one minor combined.

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2022

⚠️ No Changeset found

Latest commit: 4eb5adf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hsubox76 hsubox76 marked this pull request as ready for review October 17, 2022 20:59
dwyfrequency
dwyfrequency approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (012fd76) and merge commit (0e7caf6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EfXCGGG9w9.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

No changes between base commit (012fd76) and merge commit (0e7caf6).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/EXsvT7gnkq.html

@hsubox76 hsubox76 merged commit 3d9611e into master Oct 17, 2022
@hsubox76 hsubox76 deleted the ch-ad-versionfix branch October 17, 2022 22:09
@firebase firebase locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@egilmorez egilmorez Awaiting requested review from egilmorez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @dwyfrequency