Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API to bold #6696

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Use API to bold #6696

merged 6 commits into from
Oct 17, 2022

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Oct 13, 2022

API documenter's API doesn't seem to let you add arbitrary HTML or formatting so added bold using its API. Can't seem to do much more than that for now.

Also remove "section: []" from toc. Apparently devsite doesn't like it? But it used to?

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2022

⚠️ No Changeset found

Latest commit: 59e0d67

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2022

Size Report 1

Affected Products

  • @firebase/analytics

    TypeBase (d922816)Merge (b23304c)Diff
    esm524.8 kB24.7 kB-76 B (-0.3%)
    main26.1 kB26.0 kB-76 B (-0.3%)
  • @firebase/firestore

    TypeBase (d922816)Merge (b23304c)Diff
    browser266 kB266 kB+23 B (+0.0%)
    esm5330 kB330 kB+15 B (+0.0%)
    main531 kB531 kB-39 B (-0.0%)
    module266 kB266 kB+23 B (+0.0%)
    react-native266 kB266 kB+23 B (+0.0%)
  • @firebase/webchannel-wrapper

    TypeBase (d922816)Merge (b23304c)Diff
    esm544.7 kB44.7 kB-36 B (-0.1%)
    main54.6 kB54.6 kB-36 B (-0.1%)
    module42.4 kB42.4 kB-36 B (-0.1%)
  • bundle

    TypeBase (d922816)Merge (b23304c)Diff
    firestore (Persistence)276 kB276 kB-36 B (-0.0%)
    firestore (Query Cursors)213 kB213 kB-13 B (-0.0%)
    firestore (Query)214 kB214 kB-13 B (-0.0%)
    firestore (Read data once)202 kB202 kB-36 B (-0.0%)
    firestore (Realtime updates)205 kB205 kB-13 B (-0.0%)
    firestore (Transaction)186 kB186 kB-36 B (-0.0%)
    firestore (Write data)186 kB186 kB-36 B (-0.0%)
  • firebase

    TypeBase (d922816)Merge (b23304c)Diff
    firebase-compat.js740 kB740 kB-6 B (-0.0%)
    firebase-firestore-compat.js314 kB313 kB-6 B (-0.0%)
    firebase-firestore.js314 kB314 kB-58 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BOtXrnu2w8.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 13, 2022

Size Analysis Report 1

This report is too large (67,129 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SzNNshsyFb.html

@hsubox76 hsubox76 marked this pull request as ready for review October 14, 2022 17:22
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsubox76 hsubox76 merged commit 012fd76 into master Oct 17, 2022
@hsubox76 hsubox76 deleted the ch-doc-order-2 branch October 17, 2022 20:39
@firebase firebase locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants