Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use API to bold #6696

Merged
merged 6 commits into from
Oct 17, 2022
Merged

Use API to bold #6696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6e9f73
markdown
hsubox76 Oct 13, 2022
fb73d85
Do bolding right
hsubox76 Oct 13, 2022
8cc076a
Try h4
hsubox76 Oct 13, 2022
3503ef9
try h4 right
hsubox76 Oct 13, 2022
f3b2d27
that didnt work
hsubox76 Oct 13, 2022
59e0d67
bump version and remove "section: []"
hsubox76 Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion repo-scripts/api-documenter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@firebase/api-documenter",
"version": "0.2.0",
"version": "0.2.1",
"description": "Read JSON files from api-extractor, generate documentation pages",
"repository": {
"directory": "repo-scripts/documenter",
Expand Down
5 changes: 3 additions & 2 deletions repo-scripts/api-documenter/src/documenters/MarkdownDocumenter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,13 +975,14 @@ page_type: reference
// Header for each group of functions grouped by first param.
// Doesn't make sense if there's only one group.
const headerText = paramKey ? `function(${paramKey}...)` : 'function()';
const formattedHeaderText = `<strong>${headerText}</strong>`;
if (sortedFunctionsFirstParamKeys.length > 1) {
finalFunctionsTable.addRow(
new DocTableRow({ configuration }, [
new DocTableCell({ configuration }, [
new DocParagraph({ configuration }, [
new DocPlainText({ configuration, text: formattedHeaderText })
new DocEmphasisSpan({ configuration, bold: true }, [
new DocPlainText({ configuration, text: headerText })
])
])
])
])
Expand Down
3 changes: 1 addition & 2 deletions repo-scripts/api-documenter/src/toc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,7 @@ export function generateToc({
if (jsSdk) {
const firebaseToc: ITocItem = {
title: 'firebase',
path: `${g3Path}/index`,
section: []
path: `${g3Path}/index`
};
toc.push(firebaseToc);
}
Expand Down