Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose 'icon' field from the Firebase Messaging SDK #6722

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Expose 'icon' field from the Firebase Messaging SDK #6722

merged 4 commits into from
Oct 25, 2022

Conversation

zwu52
Copy link
Member

@zwu52 zwu52 commented Oct 24, 2022 •
edited
Loading

Fixes for b/241885017.

Would patch #6466

@zwu52 zwu52 requested a review from hsubox76 October 24, 2022 20:41
@zwu52 zwu52 requested a review from egilmorez as a code owner October 24, 2022 20:41
@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: aa8356e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/messaging Minor
firebase Patch
@firebase/messaging-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 24, 2022 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/messaging

    TypeBase (8f031b4)Merge (e0fabfd)Diff
    browser21.3 kB21.4 kB+94 B (+0.4%)
    esm526.7 kB26.8 kB+92 B (+0.3%)
    main27.4 kB27.5 kB+92 B (+0.3%)
    module21.3 kB21.4 kB+94 B (+0.4%)

  • @firebase/messaging-sw

    TypeBase (8f031b4)Merge (e0fabfd)Diff
    main30.1 kB30.2 kB+92 B (+0.3%)
    module23.3 kB23.4 kB+94 B (+0.4%)

  • bundle

    TypeBase (8f031b4)Merge (e0fabfd)Diff
    messaging (send + receive)46.3 kB46.4 kB+58 B (+0.1%)

  • firebase

    TypeBase (8f031b4)Merge (e0fabfd)Diff
    firebase-compat.js740 kB740 kB+98 B (+0.0%)
    firebase-messaging-compat.js38.2 kB38.3 kB+98 B (+0.3%)
    firebase-messaging-sw.js26.0 kB26.0 kB+55 B (+0.2%)
    firebase-messaging.js24.8 kB24.9 kB+55 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/JVEwzoHVrV.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 24, 2022 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/messaging

    • deleteToken

      Size

      TypeBase (8f031b4)Merge (e0fabfd)Diff
      size12.7 kB12.8 kB+58 B (+0.5%)
      size-with-ext-deps38.5 kB38.5 kB+58 B (+0.2%)

    • getMessaging

      Size

      TypeBase (8f031b4)Merge (e0fabfd)Diff
      size13.2 kB13.2 kB+58 B (+0.4%)
      size-with-ext-deps46.0 kB46.1 kB+58 B (+0.1%)

    • getToken

      Size

      TypeBase (8f031b4)Merge (e0fabfd)Diff
      size12.6 kB12.7 kB+58 B (+0.5%)
      size-with-ext-deps38.3 kB38.4 kB+58 B (+0.2%)

    • isSupported

      Size

      TypeBase (8f031b4)Merge (e0fabfd)Diff
      size13.0 kB13.0 kB+58 B (+0.4%)
      size-with-ext-deps38.6 kB38.7 kB+58 B (+0.2%)

    • onMessage

      Size

      TypeBase (8f031b4)Merge (e0fabfd)Diff
      size12.7 kB12.8 kB+58 B (+0.5%)
      size-with-ext-deps38.5 kB38.5 kB+58 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FtHUT1oGLq.html

@github-actions github-actions bot added the doc-changes PRs that affect docs label Oct 24, 2022
@dwyfrequency
Copy link
Contributor

Can you also run the formatter locally? Seems to be an issue there

@zwu52 zwu52 requested a review from dwyfrequency October 25, 2022 17:54
dwyfrequency
dwyfrequency approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@dwyfrequency dwyfrequency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwu52 zwu52 merged commit 4b9da74 into master Oct 25, 2022
@zwu52 zwu52 deleted the add_icon branch October 25, 2022 19:20
@google-oss-bot google-oss-bot mentioned this pull request Oct 25, 2022
Merged
@zwu52 zwu52 mentioned this pull request Oct 26, 2022
Merged
@firebase firebase locked and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dwyfrequency dwyfrequency dwyfrequency approved these changes

@hsubox76 hsubox76 Awaiting requested review from hsubox76

@egilmorez egilmorez Awaiting requested review from egilmorez

@allspain allspain Awaiting requested review from allspain

Assignees

@egilmorez egilmorez

Labels
doc-changes PRs that affect docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zwu52 @google-oss-bot @dwyfrequency @egilmorez