Add 'icon' to '/messaging-types' #6728
Conversation
…otification' payload. Fixes for b/241885017
zwu52
requested review from
egilmorez,
dwyfrequency and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: 8a0ca1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (3f1354f) and merge commit (24247ba).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (3f1354f) and merge commit (24247ba).Test Logs |
| @@ -31,6 +31,7 @@ export interface NotificationPayload { | |||
| title?: string; | |||
| body?: string; | |||
| image?: string; | |||
| icon?: string; | |||
There was a problem hiding this comment.
Just out of curiosity I looked to see if this package (@firebase/messaging-types) is being used anywhere and it doesn't seem to be? I see it as a dependency in packages/messaging/package.json but I don't see it imported anywhere in the source code. The other instances of [product]-types packages we have are legacy typings that are only used by [product]-compat but messaging-compat doesn't seem to use anything from it, and regular v9 messaging also doesn't. Maybe we could remove it? (in a later PR)
This follows #6722 to supplement 'icon' also to the '/messaging-types' dir.
ref: b/241885017