Data Connect Product #8480
Merged
Data Connect Product #8480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit d9ed6147cb5a1b34408342193896d9153a90898c
Author: Maneesh Tewani <mtewani@google.com>
Date: Thu May 9 10:09:49 2024 -0700
Fixed issue where transport is undefined
* Addressed comments * Included api report * Removed console.log
* Began reporting client sdk information
hsubox76
reviewed
Sep 13, 2024
DellaBitta
reviewed
Sep 19, 2024
hsubox76
reviewed
Sep 19, 2024
hsubox76
reviewed
Sep 19, 2024
hsubox76
approved these changes
Sep 19, 2024
DellaBitta
requested changes
Sep 23, 2024
packages/data-connect/karma.conf.js
Outdated
| @@ -0,0 +1,34 @@ | |||
| /** | |||
| * @license | |||
| * Copyright 2017 Google LLC | |||
There was a problem hiding this comment.
Sorry, reviving this comment. Many of these files have copyrights from varying years. Shouldn't they all be 2024?
| // }, | ||
| // external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`)), | ||
| // onwarn: onWarn | ||
| // } |
There was a problem hiding this comment.
Should this still be here?
| // `Provided AppCheck credentials for the app named "${this.appName_}" ` + | ||
| // 'are invalid. This usually indicates your app was not initialized correctly.' | ||
| // ); | ||
| // } |
|
|
||
| import fs from 'fs'; | ||
| import * as path from 'path'; | ||
| // curl localhost:3628/setupSchema -X POST -d '{ |
There was a problem hiding this comment.
If this is still needed the maybe add a comment to what it's used for.
DellaBitta
requested changes
Sep 23, 2024
repo-scripts/prune-dts/tests/resolves-generics-through-inheritence.input.d.ts
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Data Connect product (v0.1.0-beta)