Skip to content

Commit

Permalink
Remove go discovery module. (#5419)
Browse files Browse the repository at this point in the history
Maybe one day we will go back and re-invest here. For now let's remove the code to avoid extra effort to keep these modules up-to-date as we extend capabilities of runtime delegate module.
  • Loading branch information
taeold authored Jan 19, 2023
1 parent 811c7b4 commit 1a8633a
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 426 deletions.
87 changes: 0 additions & 87 deletions src/deploy/functions/runtimes/golang/gomod.ts

This file was deleted.

152 changes: 0 additions & 152 deletions src/deploy/functions/runtimes/golang/index.ts

This file was deleted.

5 changes: 1 addition & 4 deletions src/deploy/functions/runtimes/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const RUNTIMES: string[] = ["nodejs10", "nodejs12", "nodejs14", "nodejs16", "nod
// Experimental runtimes are part of the Runtime type, but are in a
// different list to help guard against some day accidentally iterating over
// and printing a hidden runtime to the user.
const EXPERIMENTAL_RUNTIMES = ["go113"];
const EXPERIMENTAL_RUNTIMES: string[] = [];
export type Runtime = typeof RUNTIMES[number] | typeof EXPERIMENTAL_RUNTIMES[number];

/** Runtimes that can be found in existing backends but not used for new functions. */
Expand All @@ -34,7 +34,6 @@ const MESSAGE_FRIENDLY_RUNTIMES: Record<Runtime | DeprecatedRuntime, string> = {
nodejs14: "Node.js 14",
nodejs16: "Node.js 16",
nodejs18: "Node.js 18",
go113: "Go 1.13",
};

/**
Expand Down Expand Up @@ -109,8 +108,6 @@ export interface DelegateContext {
}

type Factory = (context: DelegateContext) => Promise<RuntimeDelegate | undefined>;
// Note: golang has been removed from delegates because it does not work and it
// is not worth having an experiment for yet.
const factories: Factory[] = [node.tryCreateDelegate];

/**
Expand Down
73 changes: 0 additions & 73 deletions src/init/features/functions/golang.ts

This file was deleted.

Loading

0 comments on commit 1a8633a

Please sign in to comment.