Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove go discovery module for CF3 #5419

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Jan 12, 2023

Maybe one day we will go back and re-invest here. For now let's remove the code to avoid extra effort to keep these modules up-to-date as we extend capabilities of runtime delegate module.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2023

Codecov Report

Base: 56.33% // Head: 56.34% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9be77ff) compared to base (a1287dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5419      +/-   ##
==========================================
+ Coverage   56.33%   56.34%   +0.01%     
==========================================
  Files         315      313       -2     
  Lines       21303    21198     -105     
  Branches     4343     4325      -18     
==========================================
- Hits        12000    11943      -57     
+ Misses       8264     8218      -46     
+ Partials     1039     1037       -2     
Impacted Files Coverage Δ
src/deploy/functions/runtimes/index.ts 54.16% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants