Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Unity export so that App does not include AppCheck files #729

Merged
merged 5 commits into from
May 17, 2023
Merged

Update Unity export so that App does not include AppCheck files #729

merged 5 commits into from
May 17, 2023

Conversation

AlmostMatt
Copy link
Contributor

@AlmostMatt AlmostMatt commented May 15, 2023 •
edited
Loading

Description

Update exports.json to match App-* and App.* instead of App*
Fix create_debug_export.py and run it.

This is relevant because previously App* was matching FirebaseCppAppCheck.bundle, when the pattern was meant to match files like FirebaseCppApp-11_0_0.bundle. As a result the App tgz was unintentionally including AppCheck files.

Testing

Build workflow based on this PR
https://github.com/firebase/firebase-unity-sdk/actions/runs/4996447348

Verified that the app.tgz produced by that build does not have redundant appcheck bundles.

Type of Change

Place an x the applicable box:

@AlmostMatt AlmostMatt changed the title Match App. and App- instead of App*. Also fix create_debug_export and… Update Unity export so that App does not include AppCheck files May 15, 2023
@AlmostMatt AlmostMatt marked this pull request as ready for review May 16, 2023 23:46
@AlmostMatt AlmostMatt requested a review from a-maurice May 16, 2023 23:50
@AlmostMatt AlmostMatt merged commit 36c3398 into main May 17, 2023
@AlmostMatt AlmostMatt mentioned this pull request May 17, 2023
Closed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label May 17, 2023
@github-actions
Copy link

github-actions bot commented May 17, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit 3a571f0
Last updated: Wed May 17 13:48 PDT 2023
View integration test log & download artifacts

Failures Configs
/home/runner/work/firebase-unity-sdk/firebase-unity-sdk/testapps/Android/app_check/testapp.apk [TEST] [ERROR] [2020] [1/2 Build OS(s): windows] [1/6 Platform(s): Android] [1/3 Test Device(s): android_target]
messaging [TEST] [ERROR] [2020] [1/2 Build OS(s): macos] [1/6 Platform(s): iOS] [1/3 Test Device(s): ios_target]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label May 17, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label May 17, 2023
@firebase firebase locked and limited conversation to collaborators Jun 17, 2023
@AlmostMatt AlmostMatt deleted the amatt-unity-export-app-and-appcheck branch August 15, 2023 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AppCheck duplicate binaries in firebase.app and firebase.app-check
2 participants
@AlmostMatt @a-maurice