fix(ui_auth): fix ResponsivePage layout causing unexpected overflows #10533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesnitsky
commented
Feb 27, 2023
| @@ -34,10 +34,6 @@ Future<void> main() async { | |||
| WidgetsFlutterBinding.ensureInitialized(); | |||
| await Firebase.initializeApp(options: DefaultFirebaseOptions.currentPlatform); | |||
|
|
|||
| if (FirebaseAuth.instance.currentUser == null) { | |||
There was a problem hiding this comment.
dropping leftovers from one of the previous PRs
lesnitsky
commented
Feb 27, 2023
| @@ -176,7 +176,7 @@ class _ResponsivePageState extends State<ResponsivePage> { | |||
| Center( | |||
| child: ConstrainedBox( | |||
| constraints: BoxConstraints(maxWidth: breakpoint), | |||
| child: IntrinsicHeight(child: content), | |||
There was a problem hiding this comment.
this is an actual layout fix :)
lesnitsky
commented
Feb 27, 2023
| @@ -24,6 +24,9 @@ String? localizedErrorText( | |||
| return labels.wrongOrNoPasswordErrorText; | |||
| case 'credential-already-in-use': | |||
| return labels.credentialAlreadyInUseErrorText; | |||
| case 'invalid-verification-code': | |||
| // TODO(@lesnitsky): localization | |||
There was a problem hiding this comment.
we will get missing labels in a single batch once firebase_ui_storage widgets are implemented
Lyokone
approved these changes
Feb 28, 2023
russellwheatley
approved these changes
Feb 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #10485
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?