Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui_auth): fix ResponsivePage layout causing unexpected overflows #10533

Merged
merged 1 commit into from
Feb 28, 2023
Merged

fix(ui_auth): fix ResponsivePage layout causing unexpected overflows #10533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/firebase_ui_auth/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,6 @@ Future<void> main() async {
WidgetsFlutterBinding.ensureInitialized();
await Firebase.initializeApp(options: DefaultFirebaseOptions.currentPlatform);

if (FirebaseAuth.instance.currentUser == null) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropping leftovers from one of the previous PRs

await FirebaseAuth.instance.signInAnonymously();
}

FirebaseUIAuth.configureProviders([
EmailAuthProvider(),
emailLinkProviderConfig,
Expand Down Expand Up @@ -71,7 +67,7 @@ class FirebaseAuthUIExample extends StatelessWidget {
String get initialRoute {
final auth = FirebaseAuth.instance;

if (auth.currentUser == null || auth.currentUser!.isAnonymous) {
if (auth.currentUser == null) {
return '/';
}

Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_ui_auth/lib/src/screens/internal/responsive_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class _ResponsivePageState extends State<ResponsivePage> {
Center(
child: ConstrainedBox(
constraints: BoxConstraints(maxWidth: breakpoint),
child: IntrinsicHeight(child: content),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an actual layout fix :)

child: content,
),
),
],
Expand Down
3 changes: 3 additions & 0 deletions packages/firebase_ui_auth/lib/src/widgets/error_text.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ String? localizedErrorText(
return labels.wrongOrNoPasswordErrorText;
case 'credential-already-in-use':
return labels.credentialAlreadyInUseErrorText;
case 'invalid-verification-code':
// TODO(@lesnitsky): localization
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will get missing labels in a single batch once firebase_ui_storage widgets are implemented

return 'The code you entered is invalid. Please try again.';

default:
return null;
Expand Down