Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Remove AndroidX warning #1341

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Oct 31, 2019

Description

Remove AndroidX warnings since now the tool provides warnings. This follows the PR flutter/plugins#2231 in the plugins repo.

This excludes firebase_crashlytics and firebase_in_app_messaging since they never included the warning.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@bparrishMines bparrishMines changed the title Cleanup [all] Remove AndroidX warning Oct 31, 2019
@bparrishMines
Copy link
Contributor Author

Ios build is failing because it is testing 13 plugins and timing out. Going to go ahead and merge. Will revert if build errors persist.

@bparrishMines bparrishMines merged commit cb14296 into firebase:master Nov 6, 2019
@bparrishMines bparrishMines deleted the cleanup branch November 6, 2019 19:24
kroikie pushed a commit to collinjackson/flutterfire that referenced this pull request Nov 15, 2019
@firebase firebase locked and limited conversation to collaborators Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants