Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[cleanup] Remove AndroidX warning #2231

Merged
merged 2 commits into from
Oct 28, 2019
Merged

[cleanup] Remove AndroidX warning #2231

merged 2 commits into from
Oct 28, 2019

Conversation

blasten
Copy link

@blasten blasten commented Oct 23, 2019

Remove AndroidX warnings since now the tool provides warnings.

@blasten blasten requested a review from mklim October 23, 2019 20:05
mklim
mklim reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@mklim mklim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gradle changes LG, but all these plugins also need their pubspec.yaml and CHANGELOG updated.

It may be easier to deal with the patch if the changes were split per-plugin, but the deletion here is so straightforward that I don't think it's really necessary.

@blasten blasten force-pushed the remove_androidx_warning branch from a65101a to fbb575c Compare October 26, 2019 05:01
@blasten blasten force-pushed the remove_androidx_warning branch from fbb575c to 12d54d9 Compare October 26, 2019 05:14
@blasten blasten force-pushed the remove_androidx_warning branch from 12d54d9 to c89ab59 Compare October 26, 2019 05:33
@blasten blasten merged commit 8160f31 into flutter:master Oct 28, 2019
@blasten blasten deleted the remove_androidx_warning branch October 28, 2019 19:04
@bparrishMines
Copy link
Contributor

@blasten @mklim Should we be doing this in the flutterfire repo too?

@blasten
Copy link
Author

blasten commented Oct 29, 2019

@bparrishMines 👍

@bparrishMines bparrishMines mentioned this pull request Oct 31, 2019
Merged
13 tasks
mormih pushed a commit to mormih/plugins that referenced this pull request Nov 17, 2019
@mormih
[cleanup] Remove AndroidX warning (flutter#2231)
261ad2b
sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request Dec 17, 2019
[cleanup] Remove AndroidX warning (flutter#2231)
8e41f1a
Akachu pushed a commit to Akachu/flutter_camera that referenced this pull request Apr 27, 2020
[cleanup] Remove AndroidX warning (flutter#2231)
77795b3
@jeffque jeffque mentioned this pull request May 9, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mklim mklim mklim left review comments

@amirh amirh Awaiting requested review from amirh

@bkonyi bkonyi Awaiting requested review from bkonyi

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

@collinjackson collinjackson Awaiting requested review from collinjackson

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@mehmetf mehmetf Awaiting requested review from mehmetf

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blasten @bparrishMines @mklim @googlebot