[JS] feat: add path prefix option to startFlowsServer

[debkanchan]

Allows you to specify an optional path prefix for flows server.

if the flow name is suggestMenuItems and path prefix is flows then the server will be available on /flows/suggestMenuItems

Applies to all flows

[pavelgj]

Suggested change

	const pathPrefix = params?.pathPrefix ? `/${params?.pathPrefix}` : '';
	const pathPrefix = params?.pathPrefix ?? '';

[pavelgj]

Suggested change

	logger.info(` - ${pathPrefix}/${f.name}`);
	const flowPath = `${pathPrefix}${f.name}`;
	logger.info(` - ${flowPath}`);

[debkanchan]

@pavelgj I think you meant to say const flowPath = `${pathPrefix}/${f.name}`;? without the / it won't work properly

[pavelgj]

The suggestion was that params.pathPrefix defaults to /, so ${pathPrefix}${f.name} would be correct. The idea is that prefix doesn't necessarily need to have a / as separator. For example, if I want to a path like /customPrefix_flowName I'd just need to specify /customPrefix_ as prefix.

I'm thinking if it's required that the path starts with / then we can validate it....

[debkanchan]

This feels very counter intuitive. I feel very rarely people would like to add a proper "prefix" to their paths rather than a parent route. having /flows/joke will be way more common than /flows_joke.

One thing we can do maybe is, have a proper "prefix" like what you're suggesting, but also through #198 we can enable devs to add parent routes like what i'm envisioning

[debkanchan]

So there could be 4 options

• flow name only ex: /joke
• prefix + flow name ex: /prefixjoke (path has to start with / for express to work iirc)
• parent route + flow name ex: /flows/joke (through [JS] feat: standalone express router #198 )
• parent + prefix + flow name ex: /flows/prefixjoke (through [JS] feat: standalone express router #198 )

[pavelgj]

Yes, and my thinking was that this is nicely covered by:

const pathPrefix = params?.pathPrefix ?? '/';
if (pathPrefix.chatAt(0) !== '/') {
  pathPrefix = '/' + pathPrefix;
  // or throw new Error('pathPrefix must start with /')
}
// ...
const flowPath = `${pathPrefix}${f.name}`;

[debkanchan]

@pavelgj made leading / default. It will now be /flowName or /prefixflowName

[pavelgj]

Suggested change

	app.post(`${pathPrefix}/${f.name}`, m);
	app.post(flowPath, m);

[pavelgj]

Suggested change

	app.post(`${pathPrefix}/${f.name}`, f.expressHandler);
	app.post(flowPath, f.expressHandler);