[JS] feat: standalone express router #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debkanchan
changed the title
|
This pr is based on top of this pr. Merge that pr before this pr to avoid unwanted changes. |
debkanchan
changed the title
debkanchan
force-pushed
the
feat/standalone-server
branch
from
087372f to
1d9dd17
Compare
debkanchan
changed the title
… into feat/standalone-server
|
I'm going to close this PR. #196 was merged, but we discussed this in chat and I think this can easily be achieved by defining a custom express server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a new function called createFlowsServer that creates a flow server but does not automatically start it. Instead it returns an express server so that it could be used alongside non flow routes