Skip to content

fix model name lookup in dotprompt plugin and add a test #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix model name lookup in dotprompt plugin and add a test #933

merged 2 commits into from
Sep 24, 2024
+26 −9

Conversation

dhiaayachi
Copy link

Fix #932

Checklist (if applicable):

  • Tested (manually, unit tested, etc.)
  • Changelog updated
  • Docs updated

yukinagae
yukinagae reviewed Sep 19, 2024
View reviewed changes
mbleigh
mbleigh approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@mbleigh mbleigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this same thing quite recently and had the same one-character fix in a local branch. LGTM.

@mbleigh mbleigh merged commit 486dc9d into firebase:main Sep 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbleigh mbleigh mbleigh approved these changes

@yukinagae yukinagae Awaiting requested review from yukinagae

Assignees

No one assigned

Labels

None yet

Projects

Genkit Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Go] When using the dotprompt plugin with a ModelName config, it will panic

3 participants

@dhiaayachi @mbleigh @yukinagae