Skip to content

fix model name lookup in dotprompt plugin and add a test #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2024
Merged

fix model name lookup in dotprompt plugin and add a test #933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c150eda
fix model name lookup in dotprompt plugin and add a test
dhiaayachi Sep 19, 2024
96f5460
refactor test to use subtests
dhiaayachi Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/plugins/dotprompt/genkit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func (p *Prompt) Generate(ctx context.Context, pr *PromptRequest, cb func(contex
return nil, errors.New("dotprompt model not in provider/name format")
}

model := ai.LookupModel(provider, name)
model = ai.LookupModel(provider, name)
if model == nil {
return nil, fmt.Errorf("no model named %q for provider %q", name, provider)
}
Expand Down
33 changes: 25 additions & 8 deletions go/plugins/dotprompt/genkit_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,31 @@ func testGenerate(ctx context.Context, req *ai.GenerateRequest, cb func(context.

func TestExecute(t *testing.T) {
testModel := ai.DefineModel("test", "test", nil, testGenerate)
p, err := New("TestExecute", "TestExecute", Config{Model: testModel})
if err != nil {
t.Fatal(err)
}
resp, err := p.Generate(context.Background(), &PromptRequest{}, nil)
if err != nil {
t.Fatal(err)
}
t.Run("Model", func(t *testing.T) {
p, err := New("TestExecute", "TestExecute", Config{Model: testModel})
if err != nil {
t.Fatal(err)
}
resp, err := p.Generate(context.Background(), &PromptRequest{}, nil)
if err != nil {
t.Fatal(err)
}
assertResponse(t, resp)
})
t.Run("ModelName", func(t *testing.T) {
p, err := New("TestExecute", "TestExecute", Config{ModelName: "test/test"})
if err != nil {
t.Fatal(err)
}
resp, err := p.Generate(context.Background(), &PromptRequest{}, nil)
if err != nil {
t.Fatal(err)
}
assertResponse(t, resp)
})
}

func assertResponse(t *testing.T, resp *ai.GenerateResponse) {
if len(resp.Candidates) != 1 {
t.Errorf("got %d candidates, want 1", len(resp.Candidates))
if len(resp.Candidates) < 1 {
Expand Down
Loading