Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fir 35200 fix connection with empty additional jdbc options #59

Merged
merged 2 commits into from
Aug 12, 2024
Merged

test: Fir 35200 fix connection with empty additional jdbc options #59

merged 2 commits into from
Aug 12, 2024

Conversation

stepansergeevitch
Copy link
Collaborator

  • Fixed handling of empty additional parameters
  • improved test coverage for spec parsing

@stepansergeevitch stepansergeevitch self-assigned this Aug 6, 2024
@stepansergeevitch stepansergeevitch requested a review from a team as a code owner August 6, 2024 09:49
ptiurin
ptiurin approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's make sure this works in Metabase UI. Just worried that :ssl parameter that's removed might be required by the metabase itself.

@stepansergeevitch stepansergeevitch merged commit 49da6da into develop Aug 12, 2024
2 checks passed
@stepansergeevitch stepansergeevitch deleted the FIR-35200-fix-connection-with-empty-additional-jdbc-options branch August 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin