test: Fix unknown date functions #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ptiurin
approved these changes
Aug 8, 2024
This offset is used to make sure we account for the start-of-week setting. Basically, if you try to get the day-of-week for a particular date, then depending on the start of the week setting you'll get a different result. Like say you have some date which is Thursday, and if start-of-week is monday you'll get 4. Yet if start-of-week is Wednesday, you'll get 2. That's why we need to substract this offset. And it's value is weird, like for Monday it's 0, for Tuesday 6, Wednesday 5 and so on. That's why the math |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented missing year, week and second date functions