Fir 35103 cannot find matching fk table id for fk field #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptiurin
approved these changes
Sep 25, 2024
Comment on lines
+233
to
+237
| (defmethod sql-jdbc.describe-table/get-table-pks :firebolt | ||
| [_ ^Connection conn db-name-or-nil table] | ||
| (let [table-name (get table :name) | ||
| schema (get table :schema) | ||
| base-sql "SELECT primary_index FROM information_schema.tables WHERE table_name = ?" |
There was a problem hiding this comment.
Should we be reporting primary index as a primary key? As far as i understand there's an important distinction - PIs are not unique.
There was a problem hiding this comment.
This is used primarily for reporting to a customer, I don't think metabase relies on PKs (since you can just report an empty set and it would still work).
stepansergeevitch
deleted the
FIR-35103-cannot-find-matching-fk-table-id-for-fk-field
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attemp to fix (atleast partially) the unable to find matching fk issue. A bunch of improvements + reporting FKs as not supported by Firebolt (which is true)