This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Upgrade react to 15.3.2 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliandescottes
force-pushed
the
upgrade-react
branch
from
b3e7ef4 to
828f96f
Compare
juliandescottes
force-pushed
the
upgrade-react
branch
from
828f96f to
593aafd
Compare
jasonLaster
approved these changes
Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested this with the debugger.
It looks like React 15.3.2 introduces a breaking change when the build target is UMD.
I had to add an alias redirecting react to ReactUMDEntry and it works fine, but I didn't find any documentation/migration info endorsing this so I feel like I am missing something here.
Note that we could instead add the alias in the debugger/reps webpack config. But at least this way, most of the complexity remains in launchpad.