[WIP] Trying out react@next #525
Conversation
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| ["module-resolver", { | |||
| "alias": { | |||
| "react-dom": "react-dom/dist/react-dom", | |||
| "react-dom": "react-dom/umd/react-dom.development", | |||
There was a problem hiding this comment.
Curious: what is the necessity for these aliases?
There was a problem hiding this comment.
Looks like it's forcing UMD instead of default (CJS) target?
There was a problem hiding this comment.
Right. I’m curious why. In the past people used to do this to speed up DEV builds (since React had too many modules). But now CJS is also a single bundle so maybe it‘s unnecessary.
There was a problem hiding this comment.
Yeah, sorry. I wasn't really trying to answer your question so much as confirming that I understood what it was doing.
Your assertion seems legit.
There was a problem hiding this comment.
@jasonLaster is the right person to answer that question, my understanding is that this has to do with how we package react within the browser toolbox.
There was a problem hiding this comment.
Here was the warning we saw:
firefox-devtools/debugger#1640
And the fix:
firefox-devtools/debugger#1731
There was a problem hiding this comment.
So the issue is due to a custom module system (per #23)? I'm not sure what “single module plugin” is.
I guess if it works around a bug for you, that’s cool, I just wanted to verify. Please not react.development bundle is not suitable for production.
|
Closing this out for now, its a good start but will take some more work to make it happen. 🙇 |
Trying out React 16 Beta
It works, but I don't think this is merge ready yet.
Mostly we've fallen behind the react train. I've updated PropTypes and CreateClass to their shims but if this moved to ES6 Modules and JSX that would help quite a bit further.