Support cygwin #11238
Open
Support cygwin #11238
+74
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faho
requested changes
Mar 7, 2025
Berrysoft
force-pushed
the
cygwin-upstream
branch
from
d5ec927 to
16fbfdb
Compare
Berrysoft
force-pushed
the
cygwin-upstream
branch
from
16fbfdb to
b26cf23
Compare
faho
requested changes
Mar 7, 2025
faho
reviewed
Mar 15, 2025
faho
reviewed
Mar 15, 2025
krobelus
reviewed
Mar 15, 2025
Berrysoft
force-pushed
the
cygwin-upstream
branch
from
d132e40 to
a100316
Compare
faho
approved these changes
Mar 16, 2025
There was a problem hiding this comment.
Looks fine by me, I think @ridiculousfish would like to take a look.
Awesome work, btw
riking
reviewed
Mar 21, 2025
| #[cfg(target_os = "cygwin")] | ||
| { | ||
| // No system wcwidth for UTF-32 on cygwin. | ||
| 0 |
There was a problem hiding this comment.
They are 0 in cygwin. You can see in the following code that it returns 0 for non-spacing characters.
https://github.com/cygwin/cygwin/blob/main/newlib/libc/string/wcwidth.c
We don't use the cygwin wcwidth function because it's UTF-16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Cygwin & MSYS2.
wchar_tis UTF-16.wcwidthisreplaced byremoved.unicode-width.wcrtombandmbrtowcare replaced byc32rtombandmbrtoc32.Fixes issue #10956, though it has been closed.
Tracking:
TODO: