Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cygwin support #2610

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

Berrysoft
Copy link

@Berrysoft Berrysoft commented Feb 25, 2025

What does this PR do

This PR adds cygwin target support.

Tracking:

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@Berrysoft Berrysoft marked this pull request as ready for review March 7, 2025 16:13
@Berrysoft Berrysoft marked this pull request as draft March 8, 2025 14:56
@Berrysoft Berrysoft marked this pull request as ready for review March 10, 2025 10:15
@Berrysoft
Copy link
Author

The CI is broken:(

@Berrysoft Berrysoft marked this pull request as draft March 12, 2025 01:45
@Berrysoft Berrysoft marked this pull request as ready for review March 12, 2025 05:57
@SteveLauC
Copy link
Member

The CI is broken:(

Weird, let me take a look

@Berrysoft
Copy link
Author

Weird, let me take a look

Hello, @SteveLauC , if you are still looking at this:) I think it's because the latest version of once_cell updates its MSRV to 1.70, larger than the MSRV of nix, 1.69.

@SteveLauC
Copy link
Member

I think it's because the latest version of once_cell updates its MSRV

So was this newer version of once_cell updated by the libc crate?

@Berrysoft
Copy link
Author

So was this newer version of once_cell updated by the libc crate?

I don't think so. libc doesn't depend on once_cell. It is tempfile.

This repo doesn't commit the Cargo.lock. In the CI, cargo tries to find the latest version that satisifies the Cargo.toml, without considering the rust-version field in Cargo.toml (this problem has been solved with resolver 3, which is the default resolver in edition 2024).

However, it seems that once_cell published a new release recently to decrease the MSRV to 1.65. So a re-run of CI should solve the problem:)

@SteveLauC
Copy link
Member

Just re-ran the CI, and they failed because SOCK_PACKET was deprecated by rust-lang/libc#4267, but since it is used explicitly for testing so I think we can #[allow(deprecated)] here

@SteveLauC
Copy link
Member

SteveLauC commented Mar 18, 2025

Weird, the FreeBSD CI was still using once_cell 1.21.0 🤔

https://github.com/nix-rust/nix/pull/2610/checks?check_run_id=38692242745

@Berrysoft
Copy link
Author

Weird, the FreeBSD CI was still using once_cell 1.21.0

Failed 5 days ago. Not today.

@SteveLauC
Copy link
Member

Failed 5 days ago. Not today.

Hmm, sorry for missing that:D

@Berrysoft
Copy link
Author

Thank you @SteveLauC , now the CI passes again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants