Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing Sound Needs Improvement #443

Closed
zicklag opened this issue Jun 15, 2022 · 0 comments · Fixed by #459
Closed

Landing Sound Needs Improvement #443

zicklag opened this issue Jun 15, 2022 · 0 comments · Fixed by #459
Assignees
Milestone

Comments

@zicklag
Copy link
Member

zicklag commented Jun 15, 2022

Currently when a fish lands on the ground, the sound is rather loud and kind of annoying when you have a lot of jumping around.

The sound effect itself is probably fine, it just needs to be quieter, and it also seems like the sounds is getting repeated when it only needs to play once.

@zicklag zicklag self-assigned this Jun 16, 2022
@zicklag zicklag moved this from Todo to In Progress in @zicklag's FishFight Tasks Jun 16, 2022
zicklag added a commit to zicklag/jumpy that referenced this issue Jun 16, 2022
@zicklag zicklag moved this from In Progress to Waiting For Merge in @zicklag's FishFight Tasks Jun 16, 2022
@zicklag zicklag added this to the v0.5 milestone Jun 16, 2022
zicklag added a commit to zicklag/jumpy that referenced this issue Jun 16, 2022
@zicklag zicklag mentioned this issue Jun 16, 2022
olefasting pushed a commit that referenced this issue Jun 30, 2022
* Remove Disabled Settings Button

Let's not show it to the users until they can actually click it.

* Increase Jump Force

* Update Macroquad Platformer

Fixes #135

* Update Maps

- Add critters
- Tweak in various other ways to make more playable

Closes #437

* Fix Object Placement When Using Context Menu

Fixes #451

* Deactivate Effect Sprites When Spawning Items

Fixes #444

* Tweak Sound Effect Volume

- Play Sounds a 40% volume. This is a stand-in until we have a proper
  volume settings menu, but I think having the sound effects quieter
  compared to the music is better for now.
- Also made the sounds for jumping and landing quieter than the rest
  of the sound effects, because they play very often and can become
  annoying if they are too loud.

* Fix Player Landing Sound Playing Multiple Times

Fixes #443

* Deny Unknown Fields Where Possible

Adds #[serde(deny_unknown_fields)] to almost all structs. We couldn't
add it to all of them because of:
serde-rs/serde#1358

* Make Items And Weapons Respawn

When an item or weapon falls out of bounds or otherwise expired, they
will now respawn after three seconds by default. The respawn delay can
be modified or disabled per-item in their JSON metadata.

* Add Bombs & Crates To Maps

Now that items can respawn it seems like a good idea to add some more of
the fun depletable ones like bombs!

* Allow Floating With Gamepad Controls

* Update Controller Default Bindings

Update the default controller keybindings and link to the config file in
the README, instead of listing the controls.

* Cargo Update

Also restricts macroquad to an exact version, because later versions
break is_key_pressed detection.

It would be worth looking into fixing it, except I don't think we'll be
using macroquad much longer.
Repository owner moved this from Waiting For Merge to Done in @zicklag's FishFight Tasks Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant