Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify (if possible) the player translation (and limits) #63

Closed
64kramsystem opened this issue Jul 10, 2022 · 3 comments · Fixed by #154
Closed

Unify (if possible) the player translation (and limits) #63

64kramsystem opened this issue Jul 10, 2022 · 3 comments · Fixed by #154
Assignees
Labels
audience:developer Related to something only developers or project members see scope:small A small and well-defined task
Milestone

Comments

@64kramsystem
Copy link
Member

64kramsystem commented Jul 10, 2022

Currently, there is separate logic to handle the player translation, for example, on user input vs. attacks.

Such logic should be merged; otherwise, additional translation processing (currently, limits) would need to be applied for each point where translations are manipulated.

A standard pattern for this is all movements should send an event, which is then processed, and applied (according to the rules).

When this is implemented, remove the dir.x < 0. condition from the player_controller system.

I see this as depending on #99, so it'll be clear which systems handle translation, and how they need to be modified (it's known already which they are, but it's confusing to operate right now, since we'd need to introduce some temporal dependency).

@odecay
Copy link
Collaborator

odecay commented Jul 25, 2022

Moving this to v0.0.4 but if anyone disagrees feel free to move it back.

@odecay odecay modified the milestones: v0.0.3, v0.4.0 Jul 25, 2022
@64kramsystem
Copy link
Member Author

64kramsystem commented Jul 25, 2022

Moving this to v0.0.4 but if anyone disagrees feel free to move it back.

It makes sense to do it for 0.0.4 (because in order to do it in a very clean way, I think it requires stages in place), however, I've thought of an easy preliminary way to do it, so that we can start fixing those pesky out-of-border movements we have now 😄

In case I'll complete this in time for 0.0.3, I'll just create the PR and change the milestone 👍, otherwise, it stays well on 0.0.4 😄

@odecay
Copy link
Collaborator

odecay commented Jul 25, 2022

Sounds good, the stage reorder was my motivation for moving to v0.0.4 also. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audience:developer Related to something only developers or project members see scope:small A small and well-defined task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants