Implement player movements clamping (currently, via helper function) #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curses! I need to solve the conflicts 🤯 |
64kramsystem
force-pushed
the
extend_movement_clamping
branch
from
db083e4 to
3d3c3c2
Compare
odecay
reviewed
Jul 26, 2022
|
bors merge |
|
Build succeeded: |
|
Yay, we have clamping 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clamp the player movements/attacks, currently via function. Once the multistage design is implemented, this can be easily split (which will actually simplify the code).
I'm marking this as closes #63 and closes #133, as this effectively fixes the problem. Once the multistage is in place, intention to move is essentially a refactoring.