Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ability to filter out is_filtered_event events #96

Closed
3 of 4 tasks
skalepp-parachutehome opened this issue Feb 23, 2023 · 10 comments
Closed
3 of 4 tasks
Assignees
Labels
priority:p4 Affects few users; pick up when available status:in_review Currently in review type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality

Comments

@skalepp-parachutehome
Copy link

Is there an existing feature request for this?

  • I have searched the existing issues

Describe the Feature

In HubSpot, there is the ability to filter out events. Ideally, you could have the ability to filter out these events and any upstream models that have this flag within the dbt_project.yml file.

Describe alternatives you've considered

Unfortunately, there isn't another alternative. I did attend office hours and spoke to the team and we agreed this might make sense as a feature.

Are you interested in contributing this feature?

  • Yes.
  • Yes, but I will need assistance and will schedule time during your office hours for guidance.
  • No.

Anything else?

No response

@fivetran-avinash
Copy link
Contributor

Thanks for explaining it all out @skalepp-parachutehome, scheduling time with us to debug in office hours, and creating an issue on our dbt_hubspot package.

We encourage you to work on this in your end and submit a PR (fork the repo and open the PR off the changes, see here for details), as this can potentially expedite shipping this issue. Let us know if you have any questions!

@ron-eventgroove
Copy link

I also have a need for the same feature. As a marketer, I appreciate the preconfigured reporting tables, however without the ability to filter out these events or have the events pre-filtered (since these are reporting tables, these events are not required), the tables are not usable. Key metrics are incorrect.

@fivetran-joemarkiewicz
Copy link
Contributor

fivetran-joemarkiewicz commented Apr 6, 2023

Thanks for sharing your experience and desire for the feature @ron-eventgroove!

@skalepp-parachutehome I noticed you were interested in opening a PR to contribute the feature. Have you been able to start working on a PR? If not, my team will look to fold this feature update into our next upcoming sprint.

Thanks!

@skalepp-parachutehome
Copy link
Author

@fivetran-joemarkiewicz - I have not had the chance. I don't want to hold this feature up for others so if you are able to bring it in, that would be great!

@fivetran-joemarkiewicz
Copy link
Contributor

Thanks for the quick reply! Our current sprint just kicked off, but I will add this to our upcoming sprint task list.

@ron-eventgroove
Copy link

Awsome, thanks @fivetran-joemarkiewicz!

@skalepp-parachutehome
Copy link
Author

@fivetran-joemarkiewicz - Was this brought into the sprint?

@fivetran-joemarkiewicz
Copy link
Contributor

Hi @skalepp-parachutehome yup! We are working on this in the current sprint. I will be sure to share more once we get a working version with these updates applied.

@fivetran-joemarkiewicz fivetran-joemarkiewicz added priority:p4 Affects few users; pick up when available type:enhancement New functionality or enhancement status:accepted Scoped and accepted into queue update_type:feature Primary focus is to add new functionality status:in_progress Currently being worked on and removed status:accepted Scoped and accepted into queue labels Apr 25, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @skalepp-parachutehome and @ron-eventgroove 👋

I have been able to get a working version of the package with this new feature included to filter out specified email events. I will kick off our internal review process shortly, but it would be great if either of you have time to test the working version of the package and confirm the email events are being properly filtered out when defining the new hubspot_using_filtered_events variable as false.

You can test the branch with the changes by using the following in your packages.yml in place of the current hubspot version.

packages:
  # You can comment out the official version for the time being
  # - package: fivetran/hubspot
  #   version: [">=0.9.0", "<0.10.0"]

  - git: https://github.com/fivetran/dbt_hubspot.git
    revision: feature/email-event-filter
    warn-unpinned: false 

Once you have this updated, be sure to save and then include the following variable in your dbt_project.yml.

vars:
  hubspot_using_filtered_events: false # True by default

After the above are applied, you can re run dbt deps and run the package models to see if the filtered events are properly being removed in your downstream models. Let me know if you are able to test and how it goes!

@fivetran-joemarkiewicz fivetran-joemarkiewicz added status:in_review Currently in review and removed status:in_progress Currently being worked on labels Apr 26, 2023
@fivetran-joemarkiewicz
Copy link
Contributor

This has been incorporated in the latest release. As such, I will close this feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:p4 Affects few users; pick up when available status:in_review Currently in review type:enhancement New functionality or enhancement update_type:feature Primary focus is to add new functionality
Projects
None yet
Development

No branches or pull requests

5 participants