Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: dbt_hubspot feature identified within FR #96
This PR will result in the following new package version:
v0.9.1
This update is only adding a variable to a staging model to filter out specified email events. This variable is
true
by default and will not filter out records for existing package users. If users want to take advantage of the variable, they may set thehubspot_using_filtered_events
variable tofalse
. As such, this is not a breaking change.Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR adds the
hubspot_using_filtered_events
variable (true
by default) to thestg_hubspot__email_event
model. When this variable is set totrue
(default behavior) there is no change to the model as it currently is built. However, if this variable is set tofalse
it will remove the designated filtered email events per theis_filtered_event
field. This is crucial for customers leveraging the filtered email event feature within HubSpot and ensure the downstream reports are not factoring in events that do not wish to include.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as “ready for review” the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:
I tested this package by performing the following steps:
filtered_event
within theemail_event
source table is included in our get_email_event_columns macro and is appropriately defined as a boolean datatype. ✅filtered_event
field is aliased asis_filtered_event
in the stg_hubspot__email_event staging model ✅hubspot_using_filtered_events
is explicitly defined astrue
, there is no change to the behavior of the model ✅hubspot_using_filtered_events
is not defined (default true), there is no change to the behavior of the model ✅hubspot_using_filtered_events
is explicitly defined asfalse
, the where clause is properly included to filter out any filtered events in the model ✅hubspot_using_filtered_events: true
has one more record than whenhubspot_using_filtered_events: false
. After checking the results, it was in fact a record whereis_filtered_event
was set as true.Based on the above steps I feel comfortable that this address the issue identified in the linked FR.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📧