feature/email-event-filter #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2
to
+8
| # - package: fivetran/hubspot_source | ||
| # version: [">=0.9.0", "<0.10.0"] | ||
|
|
||
| - git: https://github.com/fivetran/dbt_hubspot_source.git | ||
| revision: feature/email-event-filter | ||
| warn-unpinned: false | ||
|
|
There was a problem hiding this comment.
Will update before merging
CHANGELOG.md
Outdated
|
|
||
| ## Under the Hood | ||
| - The `email_event_data.csv` seed file was updated to include events that are listed as `true` for filtered_events. This is to effectively test the above mentioned feature update. | ||
| - Included `hubspot_using_filtered_events: false` as a variable declared in the final `run_models.sh` step to ensure our integration tests gain coverage over this new feature and variable. |
There was a problem hiding this comment.
I'm not seeing this config in the run_models.sh script, just in the one in source, maybe we don't need this bit here if it's something more relevant for the source package
There was a problem hiding this comment.
@fivetran-reneeli thanks for catching this! I must have accidentally removed this when I trimmed one of the run commands. Just added it back in.
fivetran-reneeli
requested changes
May 2, 2023
Co-authored-by: Renee Li <91097070+fivetran-reneeli@users.noreply.github.com>
fivetran-reneeli
approved these changes
May 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: FR #96
This PR will result in the following new package version:
v0.9.1This is simply a documentation and under the hood update based on the updates within PR #104 from the source package. As such, no breaking updates will be reflected.
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
This PR mainly includes documentation around the newly added
hubspot_using_filtered_eventsvariable (true by default) that changes the behavior of thestg_hubspot__email_eventstaging model to filter out filtered events if the variable is set tofalse. Please see PR #104 for more details around the upstream changes.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as “ready for review” the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as “ready for review”:
Please see PR #104 for the validation steps taken to ensure the changes are behaving as expected in the source. With comfort around these changes, I feel the downstream implications will behave the same and as intended.
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
📧