bugfix/created-at-update

[fivetran-joemarkiewicz]

PR Overview

This PR will address the following Issue/Feature: dbt_hubspot_source #117

This PR will result in the following new package version: v0.14.0

Since this is changing the name of a field in the end model this will be breaking.

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

🚨 Breaking Changes 🚨

• The created_at field in the hubspot__contacts model has been renamed to created_date to be consistent with the source data and avoid duplicate columns when persisting all property_* fields at the source package.

Under the Hood

• Updates to the seed files and seed file configurations for the package integration tests to ensure updates are properly tested.

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

• dbt compile
• dbt run –full-refresh
• dbt run
• dbt test
• dbt run –vars (All vars in the buildkite job)

Before marking this PR as "ready for review" the following have been applied:

• The appropriate issue has been linked and tagged
• You are assigned to the corresponding issue and this PR
• BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

• You have validated these changes and assure this PR will address the respective Issue/Feature.
• You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
• You have provided details below around the validation steps performed to gain confidence in these changes.

I was able to confirm that the field changes in the end model. Please see the source package for further validation checks.

Standard Updates

Please acknowledge that your PR contains the following standard updates:

• Package versioning has been appropriately indexed in the following locations:
  • indexed within dbt_project.yml
  • indexed within integration_tests/dbt_project.yml
• CHANGELOG has individual entries for each respective change in this PR
• README updates have been applied (if applicable)
• [n/a] DECISIONLOG updates have been updated (if applicable)
• Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

• docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

📆

[fivetran-jamie]

looks good!

[fivetran-joemarkiewicz]

@fivetran-jamie thanks for reviewing! I made some updates to my branch to account for your review notes and also included some new variables (also introduced in my source PR changes) that allow users to disable the history models if they wish. Would you be able to give another glance to make sure all looks good following my updates?

[fivetran-jamie]

looks great! approved with one changelog comment

[fivetran-jamie]

should we note which transform end models are therefore affected?

[fivetran-joemarkiewicz]

@fivetran-jamie I agree, I just added a sub bullet to show the downstream impacts. Surprisingly it was very straightforward in only impacting the relevant end models.