-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service end models #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie this PR looks great and I appreciate how you were able to leverage what we have already done in Jira to repurpose here! It was very easy to review because it was similar to my understanding of Jira and I can see this being an asset to our customers using the Service Hub feature in HubSpot.
In addition to my minor comments in the code, I have one major question when it comes to the ticket_state
. I feel this will be one of the most important property history values that customers will want to see day over day as it resembles the status of the ticket (correct me if I am wrong). One thing that confused me was this ticket_state
seemed to be inconsistent with the actual state of the ticket. For example, I saw for one ticket it was only opened for 4 days and your ticket daily history model produced only 4 records (great!). However, the ticket_state
for last day was still OPEN
? I see that we grab the state from the pipeline stage. Is this the only way to grab the state of the ticket? It may be a nuance of HubSpot and not something we can account for, but it did seem confusing during my review. What are your thoughts?
Other than that, I was able to test the variables and various incremental runs and all looks great! Once the comments here are addressed, this should be good to go!
models/service/intermediate/int_hubspot__ticket_calendar_spine.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-jamie these changes look great! Thanks for working through these 😄 I just have one last update below. After that this is good to go!
I am approving this PR but be sure to merge PR #122 into this one before regenerating the docs and preparing for release. Thanks again!
bugfix/created-at-update
PR Overview
This PR will address the following Issue/Feature:
Quarterly project to add service/ticket models
This PR will result in the following new package version:
breaking: v0.14.0
non-breaking: v0.13.1
for users who have not explicitly set
hubspot__service_enabled
to true, nothing will change (besides the tiny source package patch i added)for users who have
hubspot__service_enabled
set to true, a lot will change!! they'll have two new end models, one of which is a pretty hefty incremental model with incremental intermediate models. that's probably something a user should explicitly elect to have so...breaking?Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
for ticket history
looked at our available dataset and compared ticket changes in the source
ticket_property_history
table to the end model.for ticket enhanced model
this one was fairly straightforward, as my code is basically just dynamic joins and a call to the pre-existing
engagements_aggregated
macrofor more details see slack DM
Standard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
🎃