-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure v3 endpoint has appropriate _deleted
field
#120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Let's merge my PR into this once it is ready. Only major difference is that my PR will be a breaking change
CHANGELOG.md
Outdated
# dbt_hubspot_source v0.12.1 | ||
|
||
Teeny tiny release! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My PR is a breaking change so we can just fold that in with this but make it breaking. Something we can handle during the merge
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
…-date-and-utils-star
…ils-star feature-bug/created-date-and-utils-star
PR Overview
This PR will address the following Issue/Feature:
no issue made, i just noticed that the Service ERD has
ticket.is_deleted
in v2 of the endpoint andticket._fivetran_deleted
in v3https://docs.google.com/presentation/d/1OIPFpkqkSYAPPFfq1-yICdfArg6mmG71P-cm15cpy7U/edit#slide=id.ged1442628e_0_0 vs https://docs.google.com/presentation/d/12IRX0kbZM18vus2tr7MUp9MXSvGVn93QCnPnrgNIAhA/edit#slide=id.ged1442628e_0_0
This PR will result in the following new package version:
0.12.1
Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:
_fivetran_deleted
in the staging model and coalesce it with the old fieldis_deleted
PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":
ran
dbt test
before and after making the change and everything still succeeds. moreover, there's no fanout in downstream ticket modelsStandard Updates
Please acknowledge that your PR contains the following standard updates:
dbt Docs
Please acknowledge that after the above were all completed the below were applied to your branch:
If you had to summarize this PR in an emoji, which would it be?
💆