Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure v3 endpoint has appropriate _deleted field #120

Merged
merged 18 commits into from
Oct 30, 2023

Conversation

fivetran-jamie
Copy link
Contributor

@fivetran-jamie fivetran-jamie commented Oct 25, 2023

PR Overview

This PR will address the following Issue/Feature:

no issue made, i just noticed that the Service ERD has ticket.is_deleted in v2 of the endpoint and ticket._fivetran_deleted in v3
https://docs.google.com/presentation/d/1OIPFpkqkSYAPPFfq1-yICdfArg6mmG71P-cm15cpy7U/edit#slide=id.ged1442628e_0_0 vs https://docs.google.com/presentation/d/12IRX0kbZM18vus2tr7MUp9MXSvGVn93QCnPnrgNIAhA/edit#slide=id.ged1442628e_0_0

This PR will result in the following new package version:

0.12.1

Please detail what change(s) this PR introduces and any additional information that should be known during the review of this PR:

  • added _fivetran_deleted to the get_ticket_columns() macro
  • folded in _fivetran_deleted in the staging model and coalesce it with the old field is_deleted

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt compile
  • dbt run –full-refresh
  • dbt run
  • dbt test
  • dbt run –vars (if applicable)

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked and tagged
  • You are assigned to the corresponding issue and this PR
  • BuildKite integration tests are passing

Detailed Validation

Please acknowledge that the following validation checks have been performed prior to marking this PR as "ready for review":

  • You have validated these changes and assure this PR will address the respective Issue/Feature.
  • You are reasonably confident these changes will not impact any other components of this package or any dependent packages.
  • You have provided details below around the validation steps performed to gain confidence in these changes.

ran dbt test before and after making the change and everything still succeeds. moreover, there's no fanout in downstream ticket models

Standard Updates

Please acknowledge that your PR contains the following standard updates:

  • Package versioning has been appropriately indexed in the following locations:
    • indexed within dbt_project.yml
    • indexed within integration_tests/dbt_project.yml
  • CHANGELOG has individual entries for each respective change in this PR
  • README updates have been applied (if applicable)
  • DECISIONLOG updates have been updated (if applicable)
  • Appropriate yml documentation has been added (if applicable)

dbt Docs

Please acknowledge that after the above were all completed the below were applied to your branch:

  • docs were regenerated (unless this PR does not include any code or yml updates)

If you had to summarize this PR in an emoji, which would it be?

💆

@fivetran-jamie fivetran-jamie self-assigned this Oct 25, 2023
Copy link
Contributor

@fivetran-joemarkiewicz fivetran-joemarkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Let's merge my PR into this once it is ready. Only major difference is that my PR will be a breaking change

CHANGELOG.md Outdated
Comment on lines 1 to 3
# dbt_hubspot_source v0.12.1

Teeny tiny release!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My PR is a breaking change so we can just fold that in with this but make it breaking. Something we can handle during the merge

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>
…ils-star

feature-bug/created-date-and-utils-star
@fivetran-jamie fivetran-jamie merged commit c3e8171 into main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants