Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Upgrading Hubspot/Hubspot Source to 0.5.0: Test issues #60

Closed
2 of 9 tasks
ericalouie opened this issue Dec 31, 2021 · 2 comments
Closed
2 of 9 tasks

BUG - Upgrading Hubspot/Hubspot Source to 0.5.0: Test issues #60

ericalouie opened this issue Dec 31, 2021 · 2 comments
Labels
type:bug Something is broken or incorrect

Comments

@ericalouie
Copy link

Are you a current Fivetran customer?
Name: Erica Louie
Title: Head of Data
Company: dbt Labs

Describe the bug

  1. In the stg_hubspot_engagements.ymlfile, there are two models with tests that do not exist in the package ([see file here](https://github.com/fivetran/dbt_hubspot_source/blob/main/models/stg_hubspot__engagement.yml#L137-L171)) a. stg_hubspot__engagement_email_ccb.stg_hubspot__engagement_email_to`
  2. We've disabled several of the package's models, but I'm seeing the tests are still coming through for these disabled models (see below)
00:23:17  Running with dbt=1.0.1-rc1
00:23:17  Partial parse save file not found. Starting full parse.
00:23:29  [WARNING]: Did not find matching node for patch with name 'stg_hubspot__engagement_email_cc' in the 'models' section of file 'models/stg_hubspot__engagement.yml'
00:23:29  [WARNING]: Did not find matching node for patch with name 'stg_hubspot__engagement_email_to' in the 'models' section of file 'models/stg_hubspot__engagement.yml'
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__deal_pipeline_stage_deal_pipeline_stage_id.ba90fa6113' (models/stg_hubspot__deal.yml) depends on a node named 'stg_hubspot__deal_pipeline_stage' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__deal_pipeline_stage_deal_pipeline_stage_id.d53656553e' (models/stg_hubspot__deal.yml) depends on a node named 'stg_hubspot__deal_pipeline_stage' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__deal_pipeline_deal_pipeline_id.dff6c45403' (models/stg_hubspot__deal.yml) depends on a node named 'stg_hubspot__deal_pipeline' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__deal_pipeline_deal_pipeline_id.8a0e3cd7a3' (models/stg_hubspot__deal.yml) depends on a node named 'stg_hubspot__deal_pipeline' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__deal_deal_id.ff48693e20' (models/stg_hubspot__deal.yml) depends on a node named 'stg_hubspot__deal' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__deal_deal_id.ac1628ac69' (models/stg_hubspot__deal.yml) depends on a node named 'stg_hubspot__deal' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__contact_list_contact_list_id.036739c1b0' (models/stg_hubspot__contact.yml) depends on a node named 'stg_hubspot__contact_list' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__contact_list_contact_list_id.ff8e4cc29a' (models/stg_hubspot__contact.yml) depends on a node named 'stg_hubspot__contact_list' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__email_event_deferred_event_id.2f779e2912' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_deferred' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__email_event_deferred_event_id.80293078e0' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_deferred' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__email_event_dropped_event_id.40706bbf71' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_dropped' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__email_event_dropped_event_id.c92d449f52' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_dropped' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__email_event_forward_event_id.7f133d2dd1' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_forward' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__email_event_forward_event_id.b9a8bf63b3' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_forward' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__email_event_print_event_id.40a8ccd3f3' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_print' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__email_event_print_event_id.94d4e09b3b' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_print' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__email_event_spam_report_event_id.448320447a' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_spam_report' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__email_event_spam_report_event_id.2a56aced8f' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_spam_report' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__email_event_status_change_event_id.13105203e0' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_status_change' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__email_event_status_change_event_id.c5e80297b1' (models/stg_hubspot__email.yml) depends on a node named 'stg_hubspot__email_event_status_change' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__engagement_call_engagement_id.5ceb3917bf' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_call' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__engagement_call_engagement_id.43b4413603' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_call' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__engagement_email_engagement_id.175561ecca' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_email' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__engagement_email_engagement_id.5eeb06dcfc' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_email' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__engagement_meeting_engagement_id.18dd11dc28' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_meeting' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__engagement_meeting_engagement_id.70721fb830' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_meeting' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__engagement_note_engagement_id.244059891e' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_note' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__engagement_note_engagement_id.e2eaf5256e' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_note' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__engagement_task_engagement_id.0bbd752d82' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_task' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__engagement_task_engagement_id.0f578bc80c' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement_task' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__engagement_engagement_id.b26f4d328f' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__engagement_engagement_id.4f054187b0' (models/stg_hubspot__engagement.yml) depends on a node named 'stg_hubspot__engagement' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__ticket_ticket_id.78c6fbfcaf' (models/stg_hubspot__ticket.yml) depends on a node named 'stg_hubspot__ticket' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__ticket_ticket_id.299e7c4c53' (models/stg_hubspot__ticket.yml) depends on a node named 'stg_hubspot__ticket' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.unique_stg_hubspot__company_company_id.394a2a4ba0' (models/stg_hubspot__company.yml) depends on a node named 'stg_hubspot__company' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot_source.not_null_stg_hubspot__company_company_id.0d0a080d43' (models/stg_hubspot__company.yml) depends on a node named 'stg_hubspot__company' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__deals_deal_id.bdbfe47fcd' (models/sales/sales.yml) depends on a node named 'hubspot__deals' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__deals_deal_id.d728fe5f71' (models/sales/sales.yml) depends on a node named 'hubspot__deals' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__deal_stages_deal_stage_id.162d2d204b' (models/sales/sales.yml) depends on a node named 'hubspot__deal_stages' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__deal_stages_deal_stage_id.7fd3732373' (models/sales/sales.yml) depends on a node named 'hubspot__deal_stages' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__companies_company_id.a58ceac3f2' (models/sales/sales.yml) depends on a node named 'hubspot__companies' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__companies_company_id.687ec98e97' (models/sales/sales.yml) depends on a node named 'hubspot__companies' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__engagements_engagement_id.59b32bc0d7' (models/sales/sales.yml) depends on a node named 'hubspot__engagements' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__engagements_engagement_id.01d5c3ee5d' (models/sales/sales.yml) depends on a node named 'hubspot__engagements' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__company_history_id.f1af964b1f' (models/sales/history/history.yml) depends on a node named 'hubspot__company_history' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__company_history_id.33035793ff' (models/sales/history/history.yml) depends on a node named 'hubspot__company_history' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__deal_history_id.1cb93fca79' (models/sales/history/history.yml) depends on a node named 'hubspot__deal_history' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__deal_history_id.a1c6cd6a75' (models/sales/history/history.yml) depends on a node named 'hubspot__deal_history' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__engagement_calls_engagement_id.00f8d8357f' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_calls' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__engagement_calls_engagement_id.972572ce6c' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_calls' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__engagement_emails_engagement_id.13a39d1e09' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_emails' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__engagement_emails_engagement_id.b18e2acbde' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_emails' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__engagement_meetings_engagement_id.83a791c3df' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_meetings' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__engagement_meetings_engagement_id.3098aabcd1' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_meetings' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__engagement_notes_engagement_id.76434ac965' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_notes' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__engagement_notes_engagement_id.c9864b5001' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_notes' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__engagement_tasks_engagement_id.67738794ae' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_tasks' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__engagement_tasks_engagement_id.754d36b939' (models/sales/engagement_events/engagement_events.yml) depends on a node named 'hubspot__engagement_tasks' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__contact_lists_contact_list_id.ea9ef03bac' (models/marketing/marketing.yml) depends on a node named 'hubspot__contact_lists' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__contact_lists_contact_list_id.3bde1bb891' (models/marketing/marketing.yml) depends on a node named 'hubspot__contact_lists' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__email_event_deferred_event_id.bb75dcb83a' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_deferred' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__email_event_deferred_event_id.2c6decaa91' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_deferred' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__email_event_dropped_event_id.093040860b' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_dropped' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__email_event_dropped_event_id.5cfe4eeb95' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_dropped' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__email_event_forward_event_id.064956aaa7' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_forward' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__email_event_forward_event_id.417a73da08' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_forward' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__email_event_print_event_id.548f6cece7' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_print' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__email_event_print_event_id.9dac8a147e' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_print' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__email_event_spam_report_event_id.20aab81ec6' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_spam_report' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__email_event_spam_report_event_id.5ddca8771a' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_spam_report' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__email_event_status_change_event_id.2e5b2b72e2' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_status_change' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__email_event_status_change_event_id.a1737e44b3' (models/marketing/email_events/email_events.yml) depends on a node named 'hubspot__email_event_status_change' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_hubspot__contact_history_id.aef69ae1ec' (models/marketing/history/history.yml) depends on a node named 'hubspot__contact_history' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_hubspot__contact_history_id.eaae22e088' (models/marketing/history/history.yml) depends on a node named 'hubspot__contact_history' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_int_hubspot__email_aggregate_status_change_email_send_id.7c03e87c05' (models/marketing/intermediate/intermediate.yml) depends on a node named 'int_hubspot__email_aggregate_status_change' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_int_hubspot__email_aggregate_status_change_email_send_id.16bf74a3bc' (models/marketing/intermediate/intermediate.yml) depends on a node named 'int_hubspot__email_aggregate_status_change' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_int_hubspot__email_metrics__by_contact_list_contact_list_id.095d72d5b8' (models/marketing/intermediate/intermediate.yml) depends on a node named 'int_hubspot__email_metrics__by_contact_list' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_int_hubspot__email_metrics__by_contact_list_contact_list_id.1d3cf4caf2' (models/marketing/intermediate/intermediate.yml) depends on a node named 'int_hubspot__email_metrics__by_contact_list' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.unique_int_hubspot__engagement_metrics__by_contact_contact_id.1c156b64ed' (models/marketing/intermediate/intermediate.yml) depends on a node named 'int_hubspot__engagement_metrics__by_contact' which is disabled
00:23:30  [WARNING]: Test 'test.hubspot.not_null_int_hubspot__engagement_metrics__by_contact_contact_id.4a800df06b' (models/marketing/intermediate/intermediate.yml) depends on a node named 'int_hubspot__engagement_metrics__by_contact' which is disabled
00:23:31  [WARNING]: Configuration paths exist in your dbt_project.yml file which do not apply to any resources.
There are 2 unused configuration paths:
- tests.hubspot_source.stg_hubspot__engagement_email_cc
- tests.hubspot_source.stg_hubspot__engagement_email_to

Steps to reproduce

  1. Upgrade to package version 0.5.0
  2. Disable a majority of the models
  3. dbt clean && dbt deps && dbt seed -- you'll get a slew of the warnings above

Expected behavior
These tests should skip over if the models are disabled, I think (?) 👀

Project variables configuration

name: 'fishtown_internal_analytics'
profile: "garage-snowflake"
version: '1.0'
require-dbt-version: ">=1.0.0"
config-version: 2

model-paths: ["models"]
analysis-paths: ["analysis"]
target-path: "target"
clean-targets: ["target", "dbt_modules", "dbt_packages"]
test-paths: ["tests"]
seed-paths: ["data"]
macro-paths: ["macros"]
asset-paths: ["assets"]

vars:
.....

  zendesk_schema: fivetran_zendesk
  zendesk_database: raw
  using_schedules:            False         #Disable if you are not using schedules
  using_user_tags:            False         #Disable if you are not using user tags
  using_organization_tags:    False         #Disable if you are not using organization tags

  hubspot_source:
    hubspot_database: raw
    hubspot_schema: fivetran_hubspot

  # Marketing
  hubspot_marketing_enabled: true                        # Disables all marketing models
  hubspot_contact_enabled: true                          # Disables the contact models
  hubspot_contact_list_enabled: false                     # Disables contact list models
  hubspot_contact_list_member_enabled: false              # Disables contact list member models
  hubspot_contact_property_enabled: false                 # Disables the contact property models
  hubspot_email_event_enabled: true                      # Disables all email_event models and functionality
  hubspot_email_event_bounce_enabled: true
  hubspot_email_event_delivered_enabled: true
  hubspot_email_event_click_enabled: true
  hubspot_email_event_opens_enabled: true
  hubspot_email_event_sent_enabled: true

  hubspot_email_event_deferred_enabled: false
  hubspot_email_event_dropped_enabled: false
  hubspot_email_event_forward_enabled: false
  hubspot_email_event_print_enabled: false
  hubspot_email_event_spam_report_enabled: false
  hubspot_email_event_status_change_enabled: false
  
  hubspot_contact_merge_audit_enabled: true               # Enables contact merge auditing to be applied to final models (removes any merged contacts that are still persisting in the contact table)

  # Sales

  hubspot_sales_enabled: false                            # Disables all sales models
  hubspot_company_enabled: false
  hubspot_deal_enabled: false
  hubspot_deal_company_enabled: false
  hubspot_engagement_enabled: false                       # Disables all engagement models and functionality
  hubspot_engagement_contact_enabled: false
  hubspot_engagement_company_enabled: false
  hubspot_engagement_deal_enabled: false
  hubspot_engagement_calls_enabled: false
  hubspot_engagement_emails_enabled: false
  hubspot_engagement_meetings_enabled: false
  hubspot_engagement_notes_enabled: false
  hubspot_engagement_tasks_enabled: false

  hubspot_service_enabled: false                       # Disables all sales models

  email_metrics: ['bounces',
                'clicks',
                'deliveries',
                'opens']

# enable custom fields to be passed through
  hubspot__contact_pass_through_columns:
    - name: "property_salesforcecontactid"
      alias: "salesforce_contact_id"

.....

Package Version

packages:
  - package: dbt-labs/audit_helper
    version: 0.5.0
  - package: dbt-labs/codegen
    version: 0.5.0
  - package: dbt-labs/dbt_utils
    version: 0.8.0
  - package: dbt-labs/snowplow
    version: 0.14.0
  - package: fivetran/hubspot
    version: 0.5.0
  - package: fivetran/zendesk_source
    version: 0.5.0

Warehouse

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Additional context

Screenshots

Please indicate the level of urgency

Are you interested in contributing to this package?

  • Yes, I can do this and open a PR for your review.
  • Possibly, but I'm not quite sure how to do this. I'd be happy to do a live coding session with someone to get this fixed.
  • No, I'd prefer if someone else fixed this. I don't have the time and/or don't know what the root cause of the problem is.
@ericalouie ericalouie added the bug label Dec 31, 2021
@fivetran-joemarkiewicz
Copy link
Contributor

Hi @ericalouie thanks so much for opening this Issue!

At a high level, I have noticed similar warning messages across our packages since upgrading to dbt v1.0.0. It seems these warnings didn't populate in previous iterations of dbt, but now dbt v1.0.0 is helpfully raising them!

I looked into both of your points and found the following solutions:

  1. In the stg_hubspot_engagements.ymlfile, there are two models with tests that do not exist in the package (see file here) a. stg_hubspot__engagement_email_ccb.stg_hubspot__engagement_email_to`
  • It seems these two models never existed in this package at all. I searched through a variety of the releases (going back to the first release) and didn't find a trace of these models. I believe these are held over from development and were not noticed. This should be an easy fix of just removing these model configs in the yml file.
  1. We've disabled several of the package's models, but I'm seeing the tests are still coming through for these disabled models (see below)
  • I have seen these warnings pop up in other packages as well when we disable the models. I would have imagined that dbt would just ignore these tests since the models are disabled, but that doesn't seem to be the case. Instead they look to be coming through as warnings that they do not exist. We may need to take a similar approach to how @fivetran-jamie solved the freshness test issue. I will post back here with updates once we arrive at a solution for this bug.

@fivetran-sheringuyen
Copy link
Contributor

fivetran-sheringuyen commented Jan 26, 2022

Hi @ericalouie!

Thank you so much for bringing this issue to our attention. I have gone ahead and pushed a bugfix release removing the two models stg_hubspot__engagement_email_cc and stg_hubspot__engagement_email_to from stg_hubspot__engagement.yml. This should resolve the respective warnings for these two models. Please watch out for the 0.5.2 release of the dbt_hubspot_source package.

As for the warnings from disabled models, it looks like @jtcohen6 has opened an issue out on dbt-core to fix this.

I will be closing this ticket but if there are any more questions, please don't hesitate to reach out!

@fivetran-sheringuyen fivetran-sheringuyen added type:bug Something is broken or incorrect and removed bug labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something is broken or incorrect
Projects
None yet
Development

No branches or pull requests

3 participants