-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating models for deleted records #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
fivetran-jamie
requested changes
Jan 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly good! left some more docs-related in-line comments
14 tasks
@fivetran-sheringuyen this should solve the issue I raised in #94; I'll close my PR! |
fivetran-jamie
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you a current Fivetran customer?
Fivetran Employee
What change(s) does this PR introduce?
Updates
The
is_deleted
field has been renamed within the below models:stg_hubspot__company
(is_company_deleted
)stg_hubspot__deal
(is_deal_deleted
)stg_hubspot__ticket
(is_ticket_deleted
)The
_fivetran_deleted
field has been renamed within the below models:stg_husbpot__contact_list_member
(is_contact_list_member_deleted
)stg_hubspot__contact_list
(is_contact_list_deleted
)stg_hubspot__contact
(is_contact_list_deleted
)stg_hubspot__deal_pipeline_stage
(is_deal_pipeline_stage_deleted
)stg_hubspot__deal_pipeline
(is_deal_pipeline_deleted
)stg_hubspot__ticket_pipeline_stage
(is_ticket_pipeline_stage_deleted
)stg_hubspot__ticket_pipeline
(is_ticket_pipeline_deleted
)Features
where not coalesce(is_deleted, false)
orwhere not coalesce(_fivetran_deleted, false)
has been removed from the above models. Instead, the newis_<model>_deleted
flags will now offer customers flexibility to filter models for deleted records as necessary.Did you update the CHANGELOG?
Does this PR introduce a breaking change?
Maybe - want to discuss
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Is this PR in response to a previously created Bug or Feature Request
How did you test the PR changes?
Select which warehouse(s) were used to test the PR
Provide an emoji that best describes your current mood
💃
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.