Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating models for deleted records #96

Merged
merged 8 commits into from
Jan 11, 2023

Conversation

fivetran-sheringuyen
Copy link
Contributor

@fivetran-sheringuyen fivetran-sheringuyen commented Jan 5, 2023

Are you a current Fivetran customer?

Fivetran Employee

What change(s) does this PR introduce?

Updates

  • The is_deleted field has been renamed within the below models:

    • stg_hubspot__company ( is_company_deleted)
    • stg_hubspot__deal (is_deal_deleted)
    • stg_hubspot__ticket (is_ticket_deleted)
  • The _fivetran_deleted field has been renamed within the below models:

    • stg_husbpot__contact_list_member (is_contact_list_member_deleted)
    • stg_hubspot__contact_list (is_contact_list_deleted)
    • stg_hubspot__contact (is_contact_list_deleted)
    • stg_hubspot__deal_pipeline_stage (is_deal_pipeline_stage_deleted)
    • stg_hubspot__deal_pipeline (is_deal_pipeline_deleted)
    • stg_hubspot__ticket_pipeline_stage (is_ticket_pipeline_stage_deleted)
    • stg_hubspot__ticket_pipeline (is_ticket_pipeline_deleted)

Features

  • Filtering deleted records with the methods where not coalesce(is_deleted, false) or where not coalesce(_fivetran_deleted, false) has been removed from the above models. Instead, the new is_<model>_deleted flags will now offer customers flexibility to filter models for deleted records as necessary.

Did you update the CHANGELOG?

  • Yes

Does this PR introduce a breaking change?

  • Yes (please provide breaking change details below.)
  • No (please provide an explanation as to how the change is non-breaking below.)
    Maybe - want to discuss

Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)

  • Yes

Is this PR in response to a previously created Bug or Feature Request

How did you test the PR changes?

  • Buildkite
  • Local (please provide additional testing details below)

Select which warehouse(s) were used to test the PR

  • BigQuery
  • Redshift
  • Snowflake
  • Postgres
  • Databricks
  • Other (provide details below)

Provide an emoji that best describes your current mood

💃

Feedback

We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good! left some more docs-related in-line comments

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
models/stg_hubspot__contact.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jamesrayoub
Copy link
Contributor

@fivetran-sheringuyen this should solve the issue I raised in #94; I'll close my PR!

Copy link
Contributor

@fivetran-jamie fivetran-jamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants