Fix account_number, add common fields, and subsidiaries_pass_through_columns #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmongerlyra
force-pushed
the
lyra_fix_account_number
branch
2 times, most recently
from
e8bff8e
to
afc37d5
Compare
4 tasks
This was referenced Sep 6, 2024
Closed
jmongerlyra
changed the title
jmongerlyra
changed the title
jmongerlyra
changed the title
Merged
6 tasks
jmongerlyra
force-pushed
the
lyra_fix_account_number
branch
2 times, most recently
from
cee2b5d
to
4468b25
Compare
Fix account_number for system generated accounts.
jmongerlyra
force-pushed
the
lyra_fix_account_number
branch
from
798931d
to
ec956fe
Compare
|
I merged and rebased the branch off |
fivetran-avinash
assigned fivetran-avinash and jmongerlyra and unassigned fivetran-avinash
fivetran-avinash
approved these changes
Nov 12, 2024
fivetran-avinash
added a commit
that referenced
this pull request
Nov 13, 2024
…used fields and foreign keys (#144) Release v0.15.0 * Fix account_number, add common fields, and subsidiaries_pass_through_columns (#136) * Fix account_number for system generated accounts. * Add subsidiaries pass through columns * Add additional fields * Fix is_account_intercompany on balance_sheet * Fix account_number * Customer PR adding locations fields (#146) --------- Co-authored-by: Avinash Kunnath <108772760+fivetran-avinash@users.noreply.github.com> Co-authored-by: Jared Monger <95247581+jmongerlyra@users.noreply.github.com> Co-authored-by: Antonio Ruby Barreto <antonio.ruby.barreto@fastnedcharging.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide your name and company
Jared Monger, Lyra Health
Link the issue/feature request which this PR is meant to address
#135
Detail what changes this PR introduces and how this addresses the issue/feature request linked above.
The patch selects the system-generated account numbers for retained earnings and CTA rather than setting to NULL. It also adds commonly used fields, and the option to use
subsidiaries_pass_through_columns.Dependent on this related PR. fivetran/dbt_netsuite_source#54
How did you validate the changes introduced within this PR?
Lyra maintains a fork of this repository. These changes were tested and validated there.
Which warehouse did you use to develop these changes?
Snowflake
Did you update the CHANGELOG?
Did you update the dbt_project.yml files with the version upgrade (please leverage standard semantic versioning)? (In both your main project and integration_tests)
Feedback
We are so excited you decided to contribute to the Fivetran community dbt package! We continue to work to improve the packages and would greatly appreciate your feedback on our existing dbt packages or what you'd like to see next.
PR Template
Community Pull Request Template (default)
Maintainer Pull Request Template (to be used by maintainers)