Update sales receipt discount logic to provide negative amounts #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-avinash
changed the title
Updated line 39 amount to a case statement flipping the sign for all sales receipt discounts.
Update int_quickbooks__sales_receipt_double_entry.sql
fivetran-joemarkiewicz
requested changes
Jun 26, 2024
There was a problem hiding this comment.
@fivetran-avinash this looks great! Thanks for working through this and your validation tests made the review very straightforward!
I have a few minor suggestions and then one question in the sales_receipt model regarding if the account model still needs to be brought in. Let me know once all comments are addressed and I can re-review. Thanks!
models/double_entry_transactions/int_quickbooks__sales_receipt_double_entry.sql
Outdated
Show resolved
Hide resolved
fivetran-joemarkiewicz
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
@fivetran-avinash thanks for making the changes! This looks good to merge into the release branch!
This was referenced Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: [#127]
This PR will result in the following new package version: Will be folded into a wider release.
Not a breaking change, no columns are being removed, just modified in the existing logic.
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
int_quickbooks__sales_receipt_double_entrymodel to bring in these values properly as negative adjusted amounts in thequickbooks__general_ledger.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Consistency tests are passing on seed data! I provided a small filter for the
adjusted_amounttests in case of minuscule amount differences that might come up in warehouses but would not cause issues with the eventual amount calculation.If you had to summarize this PR in an emoji, which would it be?
☎️