fix: Deprecate pause and resume in GameLoop #1240
Conversation
|
Note: we may also make pause/resume the main methods, and redirect/deprecate start+stop. |
| } | ||
|
|
||
| void dispose() { | ||
| _ticker.dispose(); | ||
| } | ||
|
|
||
| void pause() { |
There was a problem hiding this comment.
I don't think they were meant to be the same, IIRC @erickzanardo added those to fix a bug or something
There was a problem hiding this comment.
Yes, I do remember something like this too, but I can remember exactly what bug and why, we should hold this until we can remember
There was a problem hiding this comment.
I also thought we added these, but apparently these were added by someone called @erf 20 months ago, maybe they could explain?
There was a problem hiding this comment.
@spydon hi, i took a look now at my PR where i simplified the game loop to use a Ticker. It looks like start and stop replaced the scheduleTick and unscheduleTick calls. The only different between those were that previous Duration were set to zero in pause. It think it would be fine to combine these calls. Not sure if there would be a case where e.g. the user would e.g. want to pause the callbacks, but still make the timer move forward or something like that.
There was a problem hiding this comment.
Can you file an issue for that @st-pasha since you have the most context?
There was a problem hiding this comment.
Btw, in your test, did you declare the game outside of the GameWidget?
There was a problem hiding this comment.
I've tested with the standard example from our Dashbook, I'll have to check if it recreates the game instance upon frame rotation.
There was a problem hiding this comment.
Ok, I checked again -- after making sure that the game instance is declared only once in the examples app, the "bug" disappears (i.e. the game state keeps being paused after rotating the frame or changing window size, or opening the side menu). This happens both in the main branch and in this branch.
There was a problem hiding this comment.
Super, then it works as intended!
spydon
requested review from
erickzanardo,
luanpotter,
renancaraujo and
wolfenrain
Description
GameLoopmethodspause()andresume()are marked as deprecated, with a recommendation to usestart()andstop()instead. The reason they are deprecated is because their functionality is identical to that of the other pair of methods, so no reason to keep them around... Also, propertypreviouswas made final (with a deprecated getter for backward-compatibility), since changing it externally would break GameLoop's functionality.Here's the summary of behavior changes:
start()can now be called multiple times; previously callingstart()twice would produce an errorstop()now works the same way aspause(); previously callingstop()and thenstart()would produce negative times.previousis no longer settableChecklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
This is split out of #1234