Simplify GameLoop using a Ticker #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Apr 27, 2020
|
This is a major infrastructural change. Have you tested this well and how it performs compared to the old method? |
|
I've only tested it briefly, but performance seem on par, and pausing, seem to work as before. |
erickzanardo
approved these changes
May 1, 2020
There was a problem hiding this comment.
@luanpotter I have just tested this, and everything seems to work according. I have run a couple of examples, including the particle system, which I consider to be the most resource consuming example we have, and perfomance as the same, the pause and resume engine also worked fine.
LGTM
renancaraujo
approved these changes
May 6, 2020
|
I tested this on BGUG and it seems to be working well! I think we can merge it and move forward with it :) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the
GameLoopclass using a Ticker.I believe it's essentially doing the same as before as it is an abstraction on
SchedulerBinding.scheduleFrameCallback.But please do some testing..