Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove vector_math dependency #1361

Conversation

christopherfujino
Copy link
Contributor

Description

Today, package:flame and package:flame_test depend on vector_math. However, the upstream Flutter SDK already depends on this package: https://github.com/flutter/flutter/blob/master/packages/flutter/pubspec.yaml#L15. Thus pub get will resolve both dependencies to a single package (and version solving fail if they are not compatible, which is why I suspect Flame uses such a wide version constraint).

This PR simplifies things by just removing the dependency from the pubspec's altogether. I ran pub get on both repos and there was no diff to the pubspec.lock, and the example app built and ran fine.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality. (no behavior change, existing tests should verify this)
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

Does your PR require Flame users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change. (Indicate it in the Conventional Commit prefix with a !,
    e.g. feat!:, fix!:).
  • No, this is not a breaking change.

Related Issues

@wolfenrain wolfenrain requested a review from a team February 8, 2022 20:24
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erickzanardo erickzanardo merged commit 56b33da into flame-engine:main Feb 9, 2022
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Feb 9, 2022
* remove vector_math dependency

* remove vector_math from flame_test
@christopherfujino christopherfujino deleted the remove-vector-math-dependency branch February 10, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants