fix: remove vector_math dependency #1361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today,
package:flame
andpackage:flame_test
depend onvector_math
. However, the upstream Flutter SDK already depends on this package: https://github.com/flutter/flutter/blob/master/packages/flutter/pubspec.yaml#L15. Thus pub get will resolve both dependencies to a single package (and version solving fail if they are not compatible, which is why I suspect Flame uses such a wide version constraint).This PR simplifies things by just removing the dependency from the pubspec's altogether. I ran
pub get
on both repos and there was no diff to the pubspec.lock, and the example app built and ran fine.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?
!
,e.g.
feat!:
,fix!:
).Related Issues