Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove test and flutter_test dependencies #1367

Merged
merged 3 commits into from
Feb 12, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Feb 11, 2022

Description

Similar to #1361, dependencies test and flutter_test are unnecessary, since they are part of the Flutter SDK.

Removing these dependencies is beneficial, because occasionally they create version mismatch with error messages like

Because test >=1.19.4 <1.20.0 depends on test_api 0.4.8 and test >=1.19.3 <1.19.4 depends on test_api 0.4.7, test >=1.19.3 <1.20.0 requires test_api 0.4.7 or 0.4.8.
And because test >=1.20.0 depends on test_api 0.4.9, test >=1.19.3 requires test_api 0.4.7 or 0.4.8 or 0.4.9.
Because every version of flame_test depends on flutter_test from sdk which depends on test_api 0.4.3, every version of flame_test requires test_api 0.4.3.
Thus, flame_test is incompatible with test >=1.19.3.
So, because flame depends on both test ^1.19.3 and flame_test ^1.1.0, version solving failed.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • (NA) I have updated/added tests for ALL new/updated/fixed functionality.
  • (NA) I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • (NA) I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

@st-pasha st-pasha changed the title [WIP] remove 'test' and chore: Remove test and flutter_test dependencies Feb 11, 2022
@erickzanardo erickzanardo merged commit 0ddf6d0 into flame-engine:main Feb 12, 2022
@st-pasha st-pasha deleted the ps/test-deps branch February 12, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants