fix: Fix collision detection comments and typo #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
wolfenrain,
erickzanardo,
luanpotter and
renancaraujo
erickzanardo
approved these changes
Mar 7, 2022
| CollidableType collidableType = CollidableType.active; | ||
| CollisionType collisionType = CollisionType.active; | ||
|
|
||
| @override |
There was a problem hiding this comment.
To override the paint? Yes, because otherwise the hitboxes just became big blocks when they were rendered in debugMode. I guess it could override the debug render method too, I'll have a think about it.
st-pasha
reviewed
Mar 7, 2022
st-pasha
reviewed
Mar 7, 2022
Co-authored-by: Pasha Stetsenko <stpasha@google.com>
Co-authored-by: Pasha Stetsenko <stpasha@google.com>
st-pasha
added a commit
to st-pasha/flame
that referenced
this pull request
Mar 9, 2022
* Fix collision detection comments and typo * Update packages/flame/lib/src/collisions/collision_callbacks.dart Co-authored-by: Pasha Stetsenko <stpasha@google.com> * Update doc/flame/collision_detection.md Co-authored-by: Pasha Stetsenko <stpasha@google.com> Co-authored-by: Pasha Stetsenko <stpasha@google.com>
spydon
added a commit
that referenced
this pull request
Mar 9, 2022
* ProcessQueues() method * Added deadQueue in LifecycleManager * refactor removeFromParent() * make shouldRemove non-overridable * Added lifecycle state "removing" * prevent double-removal * shouldRemove can only be set to true * eliminate _shouldRemove * rename _dead -> _dying * added adoption queue * removed nextParent * deprecate ComponentSet.clear and .removeAll * ComponentSet no longer handles removal * remove usages of shouldRemove * doc-comments * onRemove refactor * cleanup * remove obsolete paragraph in docs * rename queue dying -> removals * feat: update examples dashbook (#1398) * docs: Added tutorial for creating a bare Flame project (#1376) * feat: Add missing optional priority to SpriteBodyComponent (#1404) * Add missing optional priority to SpriteBodyComponent Gives you the option to set the priority directly when creating the component. * Add optional parameter priority Adds priority as an optional parameter * removed wrong trailing comma Added a comma at the wrong position. * feat: Added getImageLayer to flame_tiled (#1405) * feat: Create sphinx extension for integrating Flutter apps into the documentation site (#1393) * feat: adding FlameBloc mixin to allow its usage with enhanced FlameGame classes (#1399) * feat: adding FlameBloc mixin to allow its usage with enhanced FlameGame classes * fixing tests * Apply suggestions from code review Co-authored-by: Lukas Klingsbo <me@lukas.fyi> Co-authored-by: Pasha Stetsenko <stpasha@google.com> Co-authored-by: Luan Nico <luanpotter27@gmail.com> Co-authored-by: Lukas Klingsbo <me@lukas.fyi> Co-authored-by: Pasha Stetsenko <stpasha@google.com> Co-authored-by: Luan Nico <luanpotter27@gmail.com> * refactor: Organize tests in the game/ folder (#1403) * position_type_test * detectors_test * reformat projections_test * Reorganize tests in projector_test * review flame_game_test * move some cameratests * created viewport_test file * reformat camera tests * feat: Add missing optional priority to SpriteBodyComponent (#1404) * Add missing optional priority to SpriteBodyComponent Gives you the option to set the priority directly when creating the component. * Add optional parameter priority Adds priority as an optional parameter * removed wrong trailing comma Added a comma at the wrong position. * feat: Added getImageLayer to flame_tiled (#1405) * feat: Create sphinx extension for integrating Flutter apps into the documentation site (#1393) Co-authored-by: KurtLa <KurtLa@users.noreply.github.com> Co-authored-by: Munsterlander <munsterlander@users.noreply.github.com> Co-authored-by: Erick <erickzanardoo@gmail.com> * feat: improving generics on position body component (#1397) * chore(release): publish packages (#1407) - flame@1.1.0-releasecandidate.1 - flame_bloc@1.2.0-releasecandidate.1 - flame_rive@1.1.0-releasecandidate.1 - flame_test@1.2.0-releasecandidate.1 - flame_tiled@1.3.0-releasecandidate.1 * chore: fixing pub deps to allow publish (#1408) * chore(release): publish packages - flame@1.1.0-releasecandidate.1 - flame_bloc@1.2.0-releasecandidate.1 - flame_rive@1.1.0-releasecandidate.1 - flame_test@1.2.0-releasecandidate.1 - flame_tiled@1.3.0-releasecandidate.1 * chore: fixing deps to enable pub publish * fixing vector math version * chore(flame_forge2d): export all files in barrel file (#1409) * chore(release): publish packages (#1410) - flame_forge2d@0.9.0-releasecandidate.1 * chore: commented out PR template sections (#1412) * feat: Make ContactCallback begin end methods optional overrides (#1415) * feat: made begin and end optional overrides * chore: removed unecessary end override * feat: Camera as a component (#1355) * feat(collision detection)!: Use a broadphase to make collision detection more efficient (#1252) * fix: PositionBodyComponent had an async onMount, without needing (#1424) * fix: Fix collision detection comments and typo (#1422) * Fix collision detection comments and typo * Update packages/flame/lib/src/collisions/collision_callbacks.dart Co-authored-by: Pasha Stetsenko <stpasha@google.com> * Update doc/flame/collision_detection.md Co-authored-by: Pasha Stetsenko <stpasha@google.com> Co-authored-by: Pasha Stetsenko <stpasha@google.com> * feat: adding has mounted to component (#1418) * feat: adding has mounted to component * feat: pr suggestions * feat: improving hasMounted * feat: renaming hasMounted to mounted * feat: pr suggestion * chore(release): publish packages (#1427) - flame_svg@1.1.0-releasecandidate.1 - flame@1.1.0-releasecandidate.2 - flame_bloc@1.2.0-releasecandidate.2 - flame_forge2d@0.9.0-releasecandidate.2 - flame_rive@1.1.0-releasecandidate.2 - flame_test@1.2.0-releasecandidate.2 - flame_tiled@1.3.0-releasecandidate.2 * fix a test * fix broken merge * rename parent->owner in LifecycleManager * update doc-comment Co-authored-by: Erick <erickzanardoo@gmail.com> Co-authored-by: KurtLa <KurtLa@users.noreply.github.com> Co-authored-by: Munsterlander <munsterlander@users.noreply.github.com> Co-authored-by: Lukas Klingsbo <me@lukas.fyi> Co-authored-by: Luan Nico <luanpotter27@gmail.com> Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> Co-authored-by: Alejandro Santiago <dev@alestiago.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
relatve- >relativeCollidableType->CollisionTypePaint for hitboxes should be
debugPaint.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues