Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding component snapshot to Dev tools #3261

Merged
merged 5 commits into from
Aug 9, 2024

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Aug 9, 2024

Description

Adds a component render snapshot to the dev tools.

snapshot.mp4

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team August 9, 2024 16:14
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb!

imageId,
base64,
);
return FutureBuilder(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have riverpod in there, so you could use a FutureProvider if you'd want to simplify the code a bit.
But I think this is clean enough.

@erickzanardo erickzanardo enabled auto-merge (squash) August 9, 2024 16:30
@erickzanardo erickzanardo merged commit 1a57491 into main Aug 9, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/devtools-snapshot branch August 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants