Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding FlameConsole #3329

Merged
merged 21 commits into from
Oct 24, 2024
Merged

feat: Adding FlameConsole #3329

merged 21 commits into from
Oct 24, 2024

Conversation

erickzanardo
Copy link
Member

@erickzanardo erickzanardo commented Oct 7, 2024 •
edited
Loading

Description

Adds the Flame Console bridge package.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo marked this pull request as draft October 7, 2024 13:29
@erickzanardo erickzanardo marked this pull request as ready for review October 23, 2024 12:38
spydon
spydon reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this!

doc/bridge_packages/flame_console/flame_console.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_console/flame_console.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_console/flame_console.md Outdated Show resolved Hide resolved
doc/bridge_packages/flame_console/flame_console.md Outdated Show resolved Hide resolved
packages/flame_console/CHANGELOG.md Outdated Show resolved Hide resolved
packages/flame_console/lib/src/view/cursor_builder.dart Show resolved Hide resolved
packages/flame_console/lib/src/view/history_builder.dart Show resolved Hide resolved
packages/flame_console/pubspec.yaml Outdated Show resolved Hide resolved
packages/flame_console/pubspec.yaml Outdated Show resolved Hide resolved
packages/flame_console/lib/src/controller.dart Show resolved Hide resolved
spydon
spydon approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🥳

@erickzanardo erickzanardo merged commit cf5358c into main Oct 24, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/adding-flame-console branch October 24, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erickzanardo @spydon