-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Modal State Inconsistencies when closing via this.hide
#2303
Comments
Really, the best way you can clean this up for real is by stopping to use Bootstrap's modal JS (the CSS is nice for styling). Mixing DOM-based state and VDOM stuff is bound to be endlessly confusing. |
To be clear: if the proposed fixes fix the end-user behavior, then that's fine for now. But IMO, cleaning this up will greatly help with maintenance in the future. |
We're planning to eliminate bootstrap in later releases, we'll either adopt a smaller custom library, or code in custom modal logic (which might make sense given how (relatively) small it is |
The biggest problem in this particular area is the huge and very confusing mismatch between DOM-based and VDOM-based approaches to JS. This is independent from using or not using Bootstrap for styling certain things. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum. |
We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it. |
See flarum/tags#93 (comment)
The text was updated successfully, but these errors were encountered: