Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Modal State Inconsistencies when closing via this.hide #2303

Closed
askvortsov1 opened this issue Sep 23, 2020 · 6 comments
Closed
Labels
stale Issues that have had over 90 days of inactivity

Comments

@askvortsov1
Copy link
Member

See flarum/tags#93 (comment)

@franzliedke
Copy link
Contributor

Really, the best way you can clean this up for real is by stopping to use Bootstrap's modal JS (the CSS is nice for styling). Mixing DOM-based state and VDOM stuff is bound to be endlessly confusing.

@franzliedke
Copy link
Contributor

To be clear: if the proposed fixes fix the end-user behavior, then that's fine for now. But IMO, cleaning this up will greatly help with maintenance in the future.

@askvortsov1
Copy link
Member Author

We're planning to eliminate bootstrap in later releases, we'll either adopt a smaller custom library, or code in custom modal logic (which might make sense given how (relatively) small it is

@franzliedke
Copy link
Contributor

The biggest problem in this particular area is the huge and very confusing mismatch between DOM-based and VDOM-based approaches to JS. This is independent from using or not using Bootstrap for styling certain things.

@askvortsov1 askvortsov1 removed this from the 0.1.0-beta.14 milestone Sep 26, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

@stale stale bot added the stale Issues that have had over 90 days of inactivity label Dec 25, 2020
@stale
Copy link

stale bot commented Jan 24, 2021

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues that have had over 90 days of inactivity
Projects
None yet
Development

No branches or pull requests

2 participants