Mithril 2 update #93
Mithril 2 update #93
Conversation
…ng a new discussion, but not on a tag page)
askvortsov1
requested review from
dsevillamartin,
clarkwinkelmann,
franzliedke and
tankerkiller125
The reasoning behind this is explained in the comment in the code
| @@ -23,7 +23,7 @@ export default class TagsPage extends Page { | |||
| <div className="TagsPage"> | |||
| {IndexPage.prototype.hero()} | |||
| <div className="container"> | |||
| <nav className="TagsPage-nav IndexPage-nav sideNav" config={IndexPage.prototype.affixSidebar}> | |||
| <nav className="TagsPage-nav IndexPage-nav sideNav"> | |||
There was a problem hiding this comment.
No replacement for the affixSidebar stuff? 🤔
There was a problem hiding this comment.
On the TagsPage, the navbar is at the top, and is absolutely unaffixed. I believe I removed this because it didn't actually do anything (and that method was removed from IndexPage in core)
| config(...args) { | ||
| super.config(...args); | ||
| oncreate(vnode) { | ||
| super.oncreate(vnode); |
There was a problem hiding this comment.
No onupdate stuff here?
There was a problem hiding this comment.
Page title and title count doesn't change while on TagsPage. If it does changed (we just switched from a different page), oncreate will run. So onupdate shouldn't be needed.
|
|
||
| app.modal.close(); | ||
|
|
||
| m.redraw.strategy('none'); |
There was a problem hiding this comment.
I am missing an e.redraw = false here. But this change is confusing anyway. Oversight from applying modal state changes to all bundled extensions?
There was a problem hiding this comment.
It's a workaround from before when app.modal.close was broken. That being said, I kind of like how it is now, directly calling this.hide() instead of calling it through the global ModalState
There was a problem hiding this comment.
But doing so does not mark the modal as closed in the state, right?
There was a problem hiding this comment.
Well, if that's an issue here, that also affects closing modals by clicking (x), as that also calls this.hide().
There was a problem hiding this comment.
Perhaps we should build in something to clear the modal without a redraw in ModalManager's animateHide?
There was a problem hiding this comment.
Hmm, fair point. I guess we can live with it here, but both cases should be fixed at some point, as they would both mean state and view getting out of sync?
There was a problem hiding this comment.
Agreed, I'll make an issue. It doesn't seem to affect the UI, but it's still something that would be preferable to fix.
Update for Mithril 2
- TagLinkButtons now have children passed in, even though those children are not directly shown. This is because those children are used if that TagLinkButton is the active element in a dropdown.
- Since `m.redraw.strategy('all')` is no longer an option, we use keys to force a full-page rerender after rearranging tag order in the admin dashboard
Update for Mithril 2
- TagLinkButtons now have children passed in, even though those children are not directly shown. This is because those children are used if that TagLinkButton is the active element in a dropdown.
- Since `m.redraw.strategy('all')` is no longer an option, we use keys to force a full-page rerender after rearranging tag order in the admin dashboard
No description provided.