Mithril 2 modal fixes #2314
Merged
Mithril 2 modal fixes #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
force-pushed
the
as/modal-fix
branch
from
0986c8e to
65065e4
Compare
askvortsov1
requested review from
franzliedke,
dsevillamartin,
clarkwinkelmann and
tankerkiller125
65 tasks
franzliedke
reviewed
Sep 25, 2020
clarkwinkelmann
approved these changes
Sep 27, 2020
dsevillamartin
approved these changes
Sep 29, 2020
askvortsov1
force-pushed
the
as/modal-fix
branch
from
024f2e7 to
4714ed4
Compare
This reverts commit 5b157f0.
animateShow and animateHide are more descriptive
askvortsov1
force-pushed
the
as/modal-fix
branch
from
4714ed4 to
9d1a87a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
this.hidecall the globalmodal.close, fixing Investigate Modal State Inconsistencies when closing viathis.hide#2303onbeforeremovefor closing animation instead ofonremove, and only when we actually need to close the modalreadyCallbackis called on modals opened from other modals.