Rewrite ModalManager and state to Typescript #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Pi-Bouf
approved these changes
Aug 18, 2021
askvortsov1
requested changes
Aug 19, 2021
- Fixes `attrs` parameter being marked as required - Add `isModalOpen` method
davwheat
force-pushed
the
dw/rewrite-modalmanager-ts
branch
from
ea974c3 to
9017aa7
Compare
askvortsov1
approved these changes
Sep 13, 2021
davwheat
requested review from
SychO9
and removed request for
clarkwinkelmann
dsevillamartin
requested changes
Oct 16, 2021
Co-authored-by: David Sevilla Martin <6401250+datitisev@users.noreply.github.com>
SychO9
approved these changes
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #3533
Changes proposed in this pull request:
isModalOpen()methodReviewers should focus on:
Should we make
closeTimeoutprivate, or just mark it as@internal? I don't see any reason that people would use it.Confirmed