[A11Y] Add focus traps to modals and nav drawer #3018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
added
the
type/accessibility
askvortsov1
requested changes
Aug 14, 2021
askvortsov1
approved these changes
Aug 26, 2021
davwheat
force-pushed
the
dw/2663-2665-add-focus-trap
branch
from
42eb187 to
b1d68e7
Compare
dsevillamartin
approved these changes
Sep 10, 2021
dsevillamartin
requested changes
Sep 10, 2021
davwheat
force-pushed
the
dw/2663-2665-add-focus-trap
branch
3 times, most recently
from
2790899 to
4f19eab
Compare
|
YOU WILL GET CO-AUTHORSHIP OF THAT COMMIT IF IT IS THE LAST THING I DO |
SychO9
approved these changes
Nov 10, 2021
|
Rebase in progress... @datitisev you still have "requested changes" marked on this PR -- I think I addressed your comment about a breaking change, but I'll re-request your review and you can either approve, dismiss the request, or request other changes. |
davwheat
requested review from
dsevillamartin
and removed request for
dsevillamartin
Fixes issue where focus trap would remain on the drawer when it is just the app header, if the drawer was opened then the window was made larger.
Co-authored-by: David Sevilla Martin <me@datitisev.me>
davwheat
force-pushed
the
dw/2663-2665-add-focus-trap
branch
from
4f19eab to
23a03eb
Compare
davwheat
commented
Nov 19, 2021
dsevillamartin
approved these changes
Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2663
Fixes #2665
Changes proposed in this pull request:
$.click()->$.on('click'))requestAnimationFrameinstead ofsetTimeoutReviewers should focus on:
Screenshot
Confirmed